Web based family history software

Question [SOLVED] issue with css

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #1 by samark
issue with css was created by samark
Last year I had a developer help me customize a new theme for our webtrees site. All was fine. The site hasn't been changed in months but a couple weeks ago I noticed the person detail page, which used to have tabs, now has the links one below the other and when clicked on they go to another page. I have no idea what happened. Maybe something got overwritten. Can you help me find the file/ section which needs fixing?

Thanks

I tried multiple times to add attachments but as with other posts I always get an error that size exceeds limit even though they were smaller than 150kb and smaller than 800 by 800 px

Samar

Please Log in or Create an account to join the conversation.

  • fisharebest
  • Away
  • Administrator
  • Administrator
More
7 years 8 months ago #2 by fisharebest
Replied by fisharebest on topic issue with css
It would help if you posted the URL so we can see the error, but my guess is you have a javascript error on the page.

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #3 by samark

Please Log in or Create an account to join the conversation.

More
7 years 8 months ago #4 by makitso
Replied by makitso on topic issue with css
In the standard system, these tabs are styled by the jquery-ui-css style sheet. However, your html does not appear to be using this. Unfortunately, without knowing what you wanted this to look like, its probably more than a one line change.

Rob
www.skatekey.net ( webtrees 2.1 beta GitHub)
webtrees forum admin
PHP 8.1.21
Hosted at tigertech.net

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #5 by samark
Replied by samark on topic issue with css
Was I supposed to copy that over the jquery-ui-1.11.2 folder from webtrees theme folder to my folder when I created my theme?

All I did was copy themes/_custom/theme.php to my new folder and edited the code to put in my theme which extends webtrees theme

and then added my own css file there and customized.

Did I do something wrong?

Samar

Please Log in or Create an account to join the conversation.

  • fisharebest
  • Away
  • Administrator
  • Administrator
More
7 years 8 months ago #6 by fisharebest
Replied by fisharebest on topic issue with css
Your site is trying to load jquery.cookie.js

This does not exist.

This causes a javascript error.

This causes your page to fail.

Look at the javascript error log in your browser. (or use firebug plugin for firefox)

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #7 by samark
Replied by samark on topic issue with css
sorry for the stupid question, but why is it trying to load jquery.cookie.js?

and why is it missing?

Samar

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #8 by samark
Replied by samark on topic issue with css
This is the line throwing the error?

active: location.hash ? null : jQuery.cookie ("indi-tab"),

Samar

Please Log in or Create an account to join the conversation.

More
7 years 8 months ago #9 by makitso
Replied by makitso on topic issue with css
Looks like there is a missing file?

"NetworkError: 404 Not Found - kadhifamily.com/webtrees/packages/jquery...4.1/jquery.cookie.js "

Rob
www.skatekey.net ( webtrees 2.1 beta GitHub)
webtrees forum admin
PHP 8.1.21
Hosted at tigertech.net

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #10 by samark
Replied by samark on topic issue with css
I have no idea what happened here. What is the cookie file used for? I don't see this package included in the original webtrees package :(

what should I do?

Samar

Please Log in or Create an account to join the conversation.

  • fisharebest
  • Away
  • Administrator
  • Administrator
More
7 years 8 months ago #11 by fisharebest
Replied by fisharebest on topic issue with css
Old versions of webtrees used cookies (and this library) to remember which tab you selected.

New versions of webtrees use browser local storage - and do not need this library.

You are using webtrees 1.7.2. Upgrade to the latest version?

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

More
7 years 8 months ago - 7 years 8 months ago #12 by makitso
Replied by makitso on topic issue with css
Your site looks to be using webtrees 1.7.2. The file packages/jquery-cookie-1.4.1/jquery.cookie.js was removed in 1.7.3.

However, to my earlier point, it looks like you have no styling for the tabs.

<div id="tabs">
<ul>
<li class="">
<a title="A tab showing the facts and events of an individual." href="individual.php?pid=I167&ged=kadhionly&action=ajax&module=personal_facts">Facts and events</a>
</li>
<li class="">
<li class="">
<li class="">
<li class="">
</ul>
</div>

Rob
www.skatekey.net ( webtrees 2.1 beta GitHub)
webtrees forum admin
PHP 8.1.21
Hosted at tigertech.net
Last edit: 7 years 8 months ago by makitso.

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #13 by samark
Replied by samark on topic issue with css
I tried upgrading a couple months ago and my entire custom theme got erased :( so I rolled back the upgrade. Now what?

Samar

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #14 by samark
Replied by samark on topic issue with css
Makisto, the tabs were working before. And I thought since our custom theme is an extension of the webtrees theme that it would pickup the tab styling from there, right?

Samar

Please Log in or Create an account to join the conversation.

  • fisharebest
  • Away
  • Administrator
  • Administrator
More
7 years 8 months ago #15 by fisharebest
Replied by fisharebest on topic issue with css
It is *NOT* the styling that is broken.

There is a javascript error that is preventing the tabs from being initialised.

You must fix the javascript error.

I guess that upgrading webtrees will do this.

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #16 by samark
Replied by samark on topic issue with css
Yes, what I meant was when I tried upgrading, my custom theme got overwritten. How do i prevent this? So I can upgrade to fix the Javascript error

Samar

Please Log in or Create an account to join the conversation.

  • bertkoor
  • Offline
  • Platinum Member
  • Platinum Member
  • Greetings from Utrecht, Holland
More
7 years 8 months ago #17 by bertkoor
Replied by bertkoor on topic issue with css
My guess is your custom theme was not 'custom' enough but just a modified existing one (wothout giving it a proper name) and that would explain it got lost (actually overwritten) with the upgrade. Although, version 1.7.x is internally very diffrrent from 1.6.x, to such extent that modules and themes written for 1.6 and prior don't work in 1.7, so the upgrade could have forced you to remove it.

Anyway I agree: just upgrade to the latest version. Sorry you lost the customisations, but that can be reconstructed with some effort.

stamboom.BertKoor.nl runs on webtrees v1.7.13

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #18 by samark
Replied by samark on topic issue with css
Okay, so if I have to redo it how do I do resolve this:
My guess is your custom theme was not 'custom' enough but just a modified existing one (wothout giving it a proper name)

How do I give it a proper name and make it custom enough? Please can you be a little more specific so I do not repeat the same problem again

Thanks

Samar

Please Log in or Create an account to join the conversation.

More
7 years 8 months ago #19 by makitso
Replied by makitso on topic issue with css
The html that runs on your site has the links below. It suggests that your using both the webtrees theme and your custom kadhi_custom theme.

> I tried upgrading, my custom theme got overwritten. How do i prevent this?
When you upgraded did you completely replace the themes folder? If so this would have deleted any changes made to the webtrees theme and the kadhi_custom theme folder.


<link href="themes/webtrees/jquery-ui-1.11.2/jquery-ui.css" type="text/css" rel="stylesheet">
<link href="themes/webtrees/css-1.7.0/style.css" type="text/css" rel="stylesheet">
<link href=" kadhifamily.com/webtrees/themes/kadhi_custom/kadhi-v1.0.css " type="text/css" rel="stylesheet">
<link rel="stylesheet" type="text/css" href="modules_v3/tree/css/treeview.css">

Rob
www.skatekey.net ( webtrees 2.1 beta GitHub)
webtrees forum admin
PHP 8.1.21
Hosted at tigertech.net

Please Log in or Create an account to join the conversation.

  • samark
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
7 years 8 months ago #20 by samark
Replied by samark on topic issue with css
>>When you upgraded did you completely replace the themes folder? If so this would have deleted any changes made to the webtrees theme and the kadhi_custom theme folder.

I didn't do anything to the file system. Just ran the upgrade and got surprised by the result! then rolled back

Samar

Please Log in or Create an account to join the conversation.

Powered by Kunena Forum
}