Whilst small files can be uploaded to forum posts, if you have a custom theme or module to contribute please add it on the "Add-ons" page.
  • Page:
  • 1
  • 2

TOPIC: Extended Relationships Module: Feature Requests

Extended Relationships Module: Feature Requests 3 years 2 months ago #1

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
"Extended Relationships" is a custom module available here. It offers a replacement for the 'Relationships' chart, and the 'Families' tab. It provides relationship calculations via common ancestors, and shows relationships to the default individual, and between married individuals.

This thread is to discuss further feature requests. For previous discussions, see also this thread.
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #2

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
Copied from another thread:

avdl wrote:
I'd suggest some modifications that would be improments for me:

1 - activate / disactivative the module within Family view
Adding several children to a family make relationship computing begin again each time a member is added/modified ... this is long, not usefull, server loading ..
If we had an option "with relationships" beside and just like "Date differences" , user could use it when needed

2 - Possibility to give that option only for registered memebers (visitors would be unable to activate "With relationships")

3 - in Charts / Relations to me
- French language, Uncorrected should be translated "Non corrigé" and not "Incorrect"
- Close to "Coefficient of Relationship", i'd like to have the number of the different current relationships

These should be easy to implement/correct, I'll add this functionality shortly.

avdl wrote:
- i often have several relationships (Find all relationships via lowest common ancestors), sometime more than 10; thus would it be possible to have this list of expandable (with +) blocks
- the printable version is ok

I'll have to think about this, e.g. I'm not sure how to display the un-expanded relationships.

avdl wrote:
and finaly, i'd like to be able, to disallow/disactived the "Find the closest overall connections (preferably via common ancestors)" and "Find the closest overall connections "; both option won't work for me, take so much time and end with a blank page (my database is over 200000 indis, i guess that's the reason)

That's a large tree! I guess trees of this size could only be handled efficiently with more advanced graph algorithms/ a lot of preprocessing (partitioning the tree into minimally connected sub-graphs?)

Anyway, you can deselect these options via the module administration.

Thank you for your feedback!
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #3

  • Gustine
  • Gustine's Avatar
  • Offline
  • Junior
  • Posts: 167
avdl wrote:
French language, Uncorrected should be translated "Non corrigé" and not "Incorrect"
Sorry, I translated « incorrect » instead of « uncorrected »... and, of course, didn't understand why the CoR was incorrect :-(

fisharebest wrote:
I have just added an option to webtrees to search for relationships via ancestors only.
Perhaps you could now split your module in
- « Extended families tab » using this new feature,
- « Extended relationship » for more complex calculations.
webtrees 1.7.15 (+ module sosa17 + vytux_menu + ancestral fan chart + openstreetmap) - Mageia 7 (php 7.3.11)
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #4

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
I have just updated the module and included some of the requested features.

avdl wrote:
I'd suggest some modifications that would be improments for me:

1 - activate / disactivative the module within Family view
2 - Possibility to give that option only for registered memebers (visitors would be unable to activate "With relationships")

I have not added this yet - I wouldn't be helpful if it worked like 'Date Differences' or other tab toggle checkboxes, because these only show/hide content that is calculated in any case, which is not helpful wrt performance. (I don't like how this works on the facts and events tab for 'Events of close relatives' either: Events of close relatives are always loaded, even if I never want to see them)

I'm not sure about the other suggestion (To only allow this option for registered members) - To be consistent, visitors should not be able to choose these options from the relationship chart either, in that case? They can always get that information anyway (e.g. via comparing individuals in ancestor charts), so why should it be hidden here?

avdl wrote:
3 - in Charts / Relations to me
- French language, Uncorrected should be translated "Non corrigé" and not "Incorrect"
- Close to "Coefficient of Relationship", i'd like to have the number of the different current relationships
- i often have several relationships (Find all relationships via lowest common ancestors), sometime more than 10; thus would it be possible to have this list of expandable (with +) blocks

This is all included in the latest version of the module.
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
Last Edit: 3 years 2 months ago by ric2015.
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #5

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
Gustine wrote:
avdl wrote:
French language, Uncorrected should be translated "Non corrigé" and not "Incorrect"
Sorry, I translated « incorrect » instead of « uncorrected »... and, of course, didn't understand why the CoR was incorrect :-(

I have added a help text that attempts to briefly explain how the CoR is calculated and why it isn't exactly correct in all cases.

Gustine wrote:
fisharebest wrote:
I have just added an option to webtrees to search for relationships via ancestors only.
Perhaps you could now split your module in
- « Extended families tab » using this new feature,
- « Extended relationship » for more complex calculations.

I still don't see the need to split the module - You can use just the tab, just the chart, or both; this is all configurable via the Control Panel.
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
Last Edit: 3 years 2 months ago by ric2015.
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #6

  • Gustine
  • Gustine's Avatar
  • Offline
  • Junior
  • Posts: 167
I just wanted to hide the second menu « Relationship to me » (extended one).
Problem solved by modifying module.php.
webtrees 1.7.15 (+ module sosa17 + vytux_menu + ancestral fan chart + openstreetmap) - Mageia 7 (php 7.3.11)
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #7

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
Gustine wrote:
I just wanted to hide the second menu « Relationship to me » (extended one).
Problem solved by modifying module.php.

I see - But you don't have to do it that way: Just set the visibility of the 'Family' chart via 'Control Panel' > 'Modules' > 'Charts'. If you set it to 'Hide from everyone', you get the same effect.
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 months ago #8

  • Gustine
  • Gustine's Avatar
  • Offline
  • Junior
  • Posts: 167
You are right.
Thank you.
webtrees 1.7.15 (+ module sosa17 + vytux_menu + ancestral fan chart + openstreetmap) - Mageia 7 (php 7.3.11)
The administrator has disabled public write access.
Do you need a web hosting solution for your webtrees site?
If you prefer a host that specialises in webtrees, the following page lists some suppliers able to provide one for you: 

Extended Relationships Module: Feature Requests 3 years 1 month ago #9

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
avdl wrote:
I'd suggest some modifications that would be improments for me:

1 - activate / disactivative the module within Family view
Adding several children to a family make relationship computing begin again each time a member is added/modified ... this is long, not usefull, server loading ..
If we had an option "with relationships" beside and just like "Date differences" , user could use it when needed

This is now implemented in the latest version of the module: The relationships are only displayed (and loaded) when the option "Relationships" is checked.
(The checkbox itself may be disabled via Module Administration)

As a side effect of this implementation, the relationships are now always loaded asynchronously, which makes the tab display faster (as fast as the regular 'Families' tab).
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #10

  • avdl
  • avdl's Avatar
  • Offline
  • Junior
  • Posts: 146
Hello Richard,
seems you made a beautifull new version. I just installed it.
I have error messages when i want to show relationships in the Family tab:

/home/myhome/public_html/genealogie/includes/session.php:193 /home/myhome/public_html/genealogie/app/File.php:129 is_dir(): open_basedir restriction in effect.
File(/) is not within the allowed path(s): (/home/myhome/) #0 unknown:unknown ErrorException("/home/myhome/public_html/genealogie/app/File.php:129 is_dir(): open_basedir restriction in effect. File(/) is not within the allowed path(s): (/home/myhome/)") #1 /app/File.php:129 is_dir('/') #2 /app/I18N.php:379 mkdir('/cache') #3 /includes/session.php:415 init() #4 /modules_v3/extended_relationships/moduleAjax.php:8 require('/home/myhome/public_html/gen…')

My webtrees scripts are in a subfolder in my home forder and it seems the module scripts try to write outside of that path ?????
(i changed my home folder name with the string myhome in the error message)

Could you please tell me what would help ?
Thanks,
André
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #11

  • fisharebest
  • fisharebest's Avatar
  • Online
  • Administrator
  • Posts: 11685
@ric2015 - I think the problem is that you call modules_v3/exendend_relationships/moduleAjax.php directly.

The initialisation in session.php assumes you have called a PHP script in the root folder.

You can use the module.php / Module::modAction() function for this sort of thing.
Greg Roach - This email address is being protected from spambots. You need JavaScript enabled to view it. - fisharebest.webtrees.net
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #12

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
fisharebest wrote:
I think the problem is that you call modules_v3/exendend_relationships/moduleAjax.php directly.

You can use the module.php / Module::modAction() function for this sort of thing.

I had considered that - The problem with that approach in general is the performance overhead, in particular if there are a lot of ajax requests, both for session initialization (irrelevant in this particular case because that's used anyway) and module initialization. Executing ajax requests directly is noticeably faster.

Anyway, for this module it is probably acceptable (in terms of performance) to go via module.php - I'll update the module shortly.
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #13

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
avdl wrote:
I have error messages when i want to show relationships in the Family tab:

I have now updated the module (by default, ajax requests are now executed via module.php, as suggested by Greg) - Let me know if this works for you!
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #14

  • avdl
  • avdl's Avatar
  • Offline
  • Junior
  • Posts: 146
Relationship in tabs 's working allright now but Relationship Charts does not even start when i launch it from menu; no error message.
Relationship Charts did work allright with version 1.7.8.2.
Thanks,
André
Last Edit: 3 years 2 weeks ago by avdl.
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #15

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
Sorry about that - The chart is available again in the latest version. Thank you for the feedback!
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #16

  • avdl
  • avdl's Avatar
  • Offline
  • Junior
  • Posts: 146
Hello Richard,
> The chart is available again in the latest version. Thank you for the feedback!
Yes, it does.
Your module is really great, the backoffine options make it suitable for my situation (i'm only interested in direct links, other wont work for the siez of the database i'm managing)
Relationships available both in family tab and charts are a good idea, the members of my genealogical community are going to appreciate it !)
Thanks.

Here are some smal problems:
- the term "Number of relationships:" is not translated, adding this term as variable in the language file won't solve
- the ? for Uncorrected CoR (Coefficient of Relationship) help link won't work
- common ancestor relationships charts won't show common ancestor (except if the two sibling have one common parent and one different parent), the chart begins with the brther/sister relationship.

Thanks for your beautiful work,
André
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #17

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
Hi André,

Thanks again for your feedback and suggestions, I have just uploaded a new version of the module:

avdl wrote:
- the term "Number of relationships:" is not translated, adding this term as variable in the language file won't solve

It has to be translated as "(Number of relationships: %s)" - I have added a translation to 'de.csv' as an example.

avdl wrote:
- the ? for Uncorrected CoR (Coefficient of Relationship) help link won't work

This was (hopefully) the same problem as with the ajax requests, it should work now. The help text contents may still be too technical to make sense for the average user, I'm not really sure what to do about this ... Maybe add another option to skip this confusing number altogether?

avdl wrote:
- common ancestor relationships charts won't show common ancestor (except if the two sibling have one common parent and one different parent), the chart begins with the brther/sister relationship.

I have now slapped the common ancestors on top of the relationship paths, where applicable (this is configurable in the module admin options). I'm not completely satisfied with this solution (I have not included the arrows and relationship descriptions, the display would probably get too cluttered, and I wanted to preserve the original path), but I guess it's better than nothing.
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #18

  • avdl
  • avdl's Avatar
  • Offline
  • Junior
  • Posts: 146
Hi Richard,

I installed and tried the last version and it works fine.

ric2015 wrote:
It has to be translated as "(Number of relationships: %s)" - I have added a translation to 'de.csv' as an example.
French translation now works ok

ric2015 wrote:
This was (hopefully) the same problem as with the ajax requests, it should work now. The help text contents may still be too technical to make sense for the average user, I'm not really sure what to do about this ... Maybe add another option to skip this confusing number altogether?
In fact yes, the text is technical bt, to me, when clicking on this help, you're looking for such explication.
This information is not confusing to me and there's no need for an option to display it or not. If so, i think i'll still show it.

ric2015 wrote:
I have now slapped the common ancestors on top of the relationship paths, where applicable (this is configurable in the module admin options). I'm not completely satisfied with this solution (I have not included the arrows and relationship descriptions, the display would probably get too cluttered, and I wanted to preserve the original path), but I guess it's better than nothing.
It works as attended for me.
In fact, yes, the display is complex and unclear.
Wouldn't it be better, if possible, to display only one box for top couple, with both olders in that box (linked to the family) ?

Once again, your module is essential and make update and visit really pleasant.
Thanks and regards,
André
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #19

  • ric2015
  • ric2015's Avatar
  • Offline
  • Junior
  • Posts: 104
avdl wrote:
It works as attended for me.
In fact, yes, the display is complex and unclear.
Wouldn't it be better, if possible, to display only one box for top couple, with both olders in that box (linked to the family) ?

It's not so easy to display the common ancestors differently without breaking the entire grid-based layout. An alternative would be to stack them, and have the path displayed as in the case of a single common ancestor:



Would that be clearer?
Richard

webtrees 1.7.15 at cissee.de/webtrees
Custom modules for 1.7.x and 2.x (Extended Relationships, Gov4Webtrees, Shared Places, Compact Themes Adjuster) available at cissee.de
The administrator has disabled public write access.

Extended Relationships Module: Feature Requests 3 years 2 weeks ago #20

  • thomas52
  • thomas52's Avatar
  • Online
  • Frequent
  • Western North Carolina
  • Posts: 846
Oh, yes.
"Failure is an amazing teacher." (L'échec est un professeur extraordinaire.)
The administrator has disabled public write access.
  • Page:
  • 1
  • 2
Powered by Kunena Forum