Web based family history software

This Help forum is for issues relates to the latest release (1.4.6). For issues related to beta or git version please use their own Help forum.
Before asking for help please read "How to request help" by clicking on that tab above here.

Question Fatal error: ..function canDisplayDetails()

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 7 months ago - 10 years 7 months ago #1 by Jackie
Hi,

A new member of my website deleted her own record and I approved the modification too quickly. My fault. Then, I saw that error when I tried to access MY PAGE

Fatal error: Call to a member function canDisplayDetails() on a non-object in ..tetreaugenealogie.org/modules_v3/review_changes/module.php on line 122

I fixed the issue. But I thought this may interest others.

I think deleting an individual record which had pending changes created the fatal error.
Last edit: 10 years 7 months ago by Jackie.

Please Log in or Create an account to join the conversation.

More
10 years 7 months ago #2 by kiwi
Report it as a bug. It should not be possible to delete a record with pending changes.

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 7 months ago #3 by Jackie
Replied by Jackie on topic Fatal error: ..function canDisplayDetails()
Hi,

I advised Greg about it and he replied :

If the problem is reproducable, then raise a bug report.

If it was a one-off glitch with no adverse effects, then just ignore it.


My website is running on a SVN version but not the same as the SVN demo here. I'll try to reproduce it locally on my test site, and if I can reproduce it, I'll raise a bug report.

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 7 months ago #4 by Jackie
Replied by Jackie on topic Fatal error: ..function canDisplayDetails()
Hi,

My user made 83 modifications yesterday and all were on her immediate family. Added new, then changed what she had just added, then added others, then deleted others, then added others, then, changed what she had changed before, then deleted others. New user who tried different things instead of learning.. Anyways, I tried to reproduce (partially ?) what she did without success.

I had 356 modifications to approve yesterday so...

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago - 10 years 5 months ago #5 by Jackie
Replied by Jackie on topic Fatal error: ..function canDisplayDetails()
Hi,

I bring this topic back because it happened again yesterday. Same user than before.





It seems that he first added a new child to an existing family. (I erased the birth date because the person is still living)

0 @I6270@ INDI
1 NAME Joseph Roger Yvon Pierre /Tetreault/
2 GIVN Joseph Roger Yvon Pierre
2 SURN Tetreault
1 SEX M
1 BIRT
2 DATE xx xxx xxxx
2 PLAC Montréal, Québec, Canada
1 FAMC @F16527@
1 CHAN
2 DATE 02 OCT 2013
3 TIME 22:34:19


THEN, he realised that it was not the correct family. So, he erased the individual. (HOW he did that? I don't know).




EDIT : I had to reject the last (pending change), and using "Edit GEDCOM" erase the 1 CHIL @I6270@ in the family file to solved the issue.
Attachments:
Last edit: 10 years 5 months ago by Jackie.

Please Log in or Create an account to join the conversation.

More
10 years 5 months ago #6 by fisharebest
Replied by fisharebest on topic Fatal error: ..function canDisplayDetails()
FYI - The system for showing pending changes has been completely re-written for webtrees 1.5.0.

It is likely that this bug no longer exists.

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago - 10 years 5 months ago #7 by Jackie
Hi,

I repeated the steps in the DEMO stable release and I got the same issue. So, it seems to be a bug
Last edit: 10 years 5 months ago by Jackie.

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago #8 by Jackie
Hi,

Repeating the same steps in the Demo SVN. Does not erase the individual, it shows in the pending changes block

i241
View the changes

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago #9 by Jackie
Hi Greg,

Oh ! I did not see your reply before posting. Sorry.

If I understand well the new system, the pending changes block will display the indi record even if it was deleted before approval ?


Attachments:

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago - 10 years 5 months ago #10 by Jackie
Hi,

(demo SVN) When I tried to see the "View the changes", I ended up on a blank page, telling me to contact the admin. If I am the admin who should I contact to understand what is happening?

EDIT : OK, got it. I then, contact fisharebest. ;-)
Last edit: 10 years 5 months ago by Jackie.

Please Log in or Create an account to join the conversation.

More
10 years 5 months ago #11 by fisharebest
Replied by fisharebest on topic Fatal error: ..function canDisplayDetails() BUG

If I understand well the new system, the pending changes block will display the indi record even if it was deleted before approval ?


That's correct.

Also, on the accept/reject pending changes window, you can hover your mouse over each of the changes (red/blue boxes) to see more details. This will make it quicker and easier to review other people's changes.

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

More
10 years 5 months ago #12 by fisharebest
Replied by fisharebest on topic Fatal error: ..function canDisplayDetails() BUG

Jackie wrote: Hi,

(demo SVN) When I tried to see the "View the changes", I ended up on a blank page, telling me to contact the admin. If I am the admin who should I contact to understand what is happening?

EDIT : OK, got it. I then, contact fisharebest. ;-)


Interesting. It works if you are logged in as the site admin (which I am)....

I will investigate....

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago - 10 years 1 month ago #13 by Jackie
Hi Greg,

OK. I see what you mean. The admin can see that block (I was not logged in as moderator before), and he can undo the changes. In any case, the admin will have to contact the user to understand why he added that child to that family and why he deleted the child afterwards.
Attachments:
Last edit: 10 years 1 month ago by Jackie.

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago #14 by Jackie
Hi Greg,

That is a good improvement. Congratulations !

Please Log in or Create an account to join the conversation.

  • Jackie
  • Topic Author
  • Offline
  • Platinum Member
  • Platinum Member
More
10 years 5 months ago - 10 years 5 months ago #15 by Jackie
Hi Greg,

Should I not see a "Remove child" from the family in the Family pending changes (in red)?

I mean the family record will still have a 1 CHIL @Ixxxx@ ? webtrees will not remove the child from the family record if the child record is deleted ?
Last edit: 10 years 5 months ago by Jackie.

Please Log in or Create an account to join the conversation.

More
10 years 5 months ago #16 by fisharebest
Replied by fisharebest on topic Fatal error: ..function canDisplayDetails() BUG
You are correct. I'll get this fixed.

bugs.launchpad.net/webtrees/+bug/1234928

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

Powered by Kunena Forum
}