This Help forum is for issues relates to the latest release (1.7.9). For issues related to beta or github version please use their own Help forum.
Before asking for help please read "How to request help" by clicking on that tab above here."
  • Page:
  • 1

TOPIC:

Shared note always in second line 1 year 11 months ago #1

  • trejder
  • trejder's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • Posts: 155
Simple notes always starts in the same line as designation label -- whether it is single line note or first line of multi-note line. This looks OK.



Shared notes always starts in second line, leaving the line with the designation label empty. This looks weird.




Is this a bug or by design (what purpose then)?
Attachments:

Please Log in or Create an account to join the conversation.

Last edit: by trejder.

Shared note always in second line 1 year 11 months ago #2

  • fisharebest
  • fisharebest's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 14403
Notes with one line of text are shown on the same line as the "Note:" label.

Notes with two or more lines of text are shown on the next line.
Greg Roach - This email address is being protected from spambots. You need JavaScript enabled to view it. - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

Shared note always in second line 1 year 11 months ago #3

  • trejder
  • trejder's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • Posts: 155
You have confirmed, pretty much word-by-word, what I have written above. With only exception that I mixed up shared/non-shared notes with single-line/multi-line.

You haven't, however, answered, if this is by design (I assume that yes) and why (leaving empty line seems odd).

To add things up, this happens only when auto-unfold of multi-line notes is on (discussed in some previous thread of mine). If it is off, even multi-line notes appears in first line (in folded state).

Please Log in or Create an account to join the conversation.

Shared note always in second line 1 year 11 months ago #4

  • fisharebest
  • fisharebest's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 14403
Yes - it is by design.

Firstly, consider the following note:

Mother: Jane
Father: Peter

This would look strange if you had

Note: Mother: Jane
Father: Peter

Also, notes can contain markdown (e.g. tables), and you cannot indent the first line of a table.

But for single-line notes, it looks better to have it inline.
Greg Roach - This email address is being protected from spambots. You need JavaScript enabled to view it. - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

[SOLVED] Shared note always in second line 1 year 11 months ago #5

  • trejder
  • trejder's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • Posts: 155
Problem solved.

Please Log in or Create an account to join the conversation.

[SOLVED] Shared note always in second line 1 year 11 months ago #6

  • trejder
  • trejder's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • Posts: 155
Marking as solved though I am pretty sure that we should at least consider having an option to control this.

Especially given the fact that options / settings / configuration system for webtrees is just amazing and allows to control nearly every little thing out there.

Please Log in or Create an account to join the conversation.

[SOLVED] Shared note always in second line 1 year 11 months ago #7

  • trejder
  • trejder's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • Posts: 155
How can it be that all your arguments "work" when auto-unfolding of multi-line notes is enabled and "doesn't work" when it is turned off?

How can it be that we have no problems around split names or Markdown tables when we are displaying just a first line (or actually just a portion of the first line) of folded multi-line note?

Please Log in or Create an account to join the conversation.

[SOLVED] Shared note always in second line 1 year 11 months ago #8

  • fisharebest
  • fisharebest's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 14403
You did not say what you want - only that you do not like the existing logic.

Consider a two-line note. We have these options.

Collapsed:
[+] Note: line one

Expaned
[-] Note:
line one
line two
line three

What would you display differently? Perhaps this?

[-] Note: line one
          line two
          line three

This layout creates problems with the note contains wide content (e.g. tables, long URLs, or other text that does not wrap nicely).
Greg Roach - This email address is being protected from spambots. You need JavaScript enabled to view it. - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

Do you need a web hosting solution for your webtrees site?
If you prefer a host that specialises in webtrees, the following page lists some suppliers able to provide one for you: 

[SOLVED] Shared note always in second line 1 year 10 months ago #9

  • trejder
  • trejder's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • Posts: 155
Yes, exactly as you proposed in the last example.

For me personally (others may disagree) showing a completely empty line with only label looks weird.

Beside, as I said -- none of the arguments, you provided (that supports showing first line of multi-line note in a separate, second line) are working for me. Because, if multi-line note collapse is enabled by default and if multi-line note is collapsed then you do display first line (actually part of first line) of that multi-line note in the first line and you don't care whether there can be a table or some broken formatting.

So, if this works for collapsed multi-line notes then I don't understand why this doesn't work for uncollapsed ones?

Please Log in or Create an account to join the conversation.

[SOLVED] Shared note always in second line 1 year 10 months ago #10

  • fisharebest
  • fisharebest's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 14403
> Yes, exactly as you proposed in the last example.

This can leave you with very little horizontal space for the note. (Which is one of the reason it is on the next line).

Bear in mind that in other languages the translation of "Shared note" can be roughly twice as long as in English.

This is particularly problematic for notes that cannot wrap (e.g. tables). They either get cropped or they break out of the layout.

There is already an open issue for "wide notes don't fit" - github.com/fisharebest/webtrees/issues/1427
The solution will almost certainly be to add a horizontal scroll bar to the note.

> For me personally (others may disagree) showing a completely empty line with only label looks weird.

If my memory serves me correctly, these were displayed as "inline blocks" (as you are requesting) a very long time ago, but it was changed to the currently layout by popular request.

If anyone else has an opinion on this, please share it.
Greg Roach - This email address is being protected from spambots. You need JavaScript enabled to view it. - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

  • Page:
  • 1
Powered by Kunena Forum