Question Historic events: visibility
- Franz Frese
- Topic Author
- Offline
- Elite Member
Less
More
2 weeks 5 days ago #1
by Franz Frese
Historic events: visibility was created by Franz Frese
Since version 2.2 the display of the historic events depends on the language setting of the browser.
I think I do not like that.
What do you mean?
I think I do not like that.
What do you mean?
Please Log in or Create an account to join the conversation.
- kiwi
- Offline
- Platinum Member
2 weeks 5 days ago #2
by kiwi
Nigel
www.our-families.info
Replied by kiwi on topic Historic events: visibility
Saying you don’t like it isn’t very helpful. What is the actual problem you would like to discuss?Since version 2.2 the display of the historic events depends on the language setting of the browser.
I think I do not like that.
What do you mean?
Nigel
www.our-families.info
Please Log in or Create an account to join the conversation.
- Franz Frese
- Topic Author
- Offline
- Elite Member
2 weeks 5 days ago #3
by Franz Frese
Replied by Franz Frese on topic Historic events: visibility
Discussion is about a person living in Great Britain and I do not see his presidents , as my browser is german.
And for someone living in germany the austrian presidents (and the german ones) are shown. That is bad.
And for someone living in germany the austrian presidents (and the german ones) are shown. That is bad.
Please Log in or Create an account to join the conversation.
- fisharebest
- Offline
- Administrator
2 weeks 5 days ago #4
by fisharebest
Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net
Replied by fisharebest on topic Historic events: visibility
This is not new for webtrees 2.2. It has always worked like this.
Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net
Please Log in or Create an account to join the conversation.
- Franz Frese
- Topic Author
- Offline
- Elite Member
2 weeks 4 days ago #5
by Franz Frese
new in version 2.2 is: The language is a parameter. All historic user modules had to be changed to reflect that
the last 2.1 version is
That changed in 2.2 to:
Nevertheless the language of the browser can be used (and is sometimes used) to decide if an event will be shown.
That results for example in showing for me (german language browser) Austrian Historic events for individuums that never lived their whole live in Austria (and who emigrated to America .... ) and vice versa you (browser is en) will never see any historic austrian event...
Replied by Franz Frese on topic Historic events: visibility
Sorry for my wrong conclusion:This is not new for webtrees 2.2. It has always worked like this.
new in version 2.2 is: The language is a parameter. All historic user modules had to be changed to reflect that
the last 2.1 version is
Code:
public function historicEventsAll(): Collection
Code:
public function historicEventsAll(string $language_tag): Collection
Nevertheless the language of the browser can be used (and is sometimes used) to decide if an event will be shown.
That results for example in showing for me (german language browser) Austrian Historic events for individuums that never lived their whole live in Austria (and who emigrated to America .... ) and vice versa you (browser is en) will never see any historic austrian event...
Please Log in or Create an account to join the conversation.
- hermann
- Offline
- Elite Member
2 weeks 2 days ago - 2 weeks 2 days ago #6
by hermann
Hermann
Designer of the custom module "Extended Family"
webtrees 2.1.22 (all custom modules installed, PHP 8.3.12, MariaDB 10.6) @ ahnen.hartenthaler.eu
Replied by hermann on topic Historic events: visibility
I just updated my historic data custom module "
German-Chancellors-Presidents
" using the new parameter. Not to decide which President you as user will see or not see. But to decide if the link to President Olaf Scholz goes to the German, the English or the Catalan Wikipedia. So for me, the new parameter makes sense.
The problem I see with such historic data timelines is that it is difficult to tailor them to suit. You can display timelines for different topics and regions (pandemics, battles, wars, political and social events in several countries). But if the family tree includes people from all regions of the world, the timeline for my Upper Austrian ancestors should look different than for people in the USA at the same time. But there are also emigrants from Austria to the USA, for whom events in both countries are interesting. And different historical events are relevant for a farmer than for a trader who traveled a lot.
Then the user of webtrees comes into play. A Chinese person who looks at one of my ancestors might be interested in what happened in China at the time to put it into context, because he knows the history there well and that might help him.
In short, the solution would be timelines dynamically generated by an AI that are tailored for the individuals in my tree and their living environment and suitable for the reader. I should try that sometimes. But now we have to live with the compromise we have. webtrees offers much more than any other genealogical program.
The problem I see with such historic data timelines is that it is difficult to tailor them to suit. You can display timelines for different topics and regions (pandemics, battles, wars, political and social events in several countries). But if the family tree includes people from all regions of the world, the timeline for my Upper Austrian ancestors should look different than for people in the USA at the same time. But there are also emigrants from Austria to the USA, for whom events in both countries are interesting. And different historical events are relevant for a farmer than for a trader who traveled a lot.
Then the user of webtrees comes into play. A Chinese person who looks at one of my ancestors might be interested in what happened in China at the time to put it into context, because he knows the history there well and that might help him.
In short, the solution would be timelines dynamically generated by an AI that are tailored for the individuals in my tree and their living environment and suitable for the reader. I should try that sometimes. But now we have to live with the compromise we have. webtrees offers much more than any other genealogical program.
Hermann
Designer of the custom module "Extended Family"
webtrees 2.1.22 (all custom modules installed, PHP 8.3.12, MariaDB 10.6) @ ahnen.hartenthaler.eu
Last edit: 2 weeks 2 days ago by hermann.
Please Log in or Create an account to join the conversation.
- Sir Peter
- Offline
- Premium Member
Less
More
- Posts: 508
2 weeks 2 days ago - 2 weeks 2 days ago #7
by Sir Peter
Peter
Replied by Sir Peter on topic Historic events: visibility
I like the option to provide language specific events or descriptions, links, etc. I don't like that for most modules (if not all) no default is provided which causes no historic events being shown at all.I suggest to add "default:" to one of the existing language variants, mostly english, e. g.
instead of
Code:
public function historicEventsAll(): Collection
{
switch (I18N::languageTag()) {
default:
case 'en-AU':
case 'en-GB':
case 'en-US':
return new Collection([
"1 EVEN William II\n2 TYPE English King\n2 DATE FROM @#DJULIAN@ 26 SEP 1087 TO @#DJULIAN@ 02 AUG 1100",
...
"1 EVEN Charles III\n2 TYPE British King\n2 DATE FROM 08 SEP 2022",
]);
Code:
public function historicEventsAll(): Collection
{
switch (I18N::languageTag()) {
case 'en-AU':
case 'en-GB':
case 'en-US':
return new Collection([
"1 EVEN William II\n2 TYPE English King\n2 DATE FROM @#DJULIAN@ 26 SEP 1087 TO @#DJULIAN@ 02 AUG 1100",
...
"1 EVEN Charles III\n2 TYPE British King\n2 DATE FROM 08 SEP 2022",
]);
default:
return new Collection();
Peter
Last edit: 2 weeks 2 days ago by Sir Peter. Reason: Reformatting
Please Log in or Create an account to join the conversation.
- Franz Frese
- Topic Author
- Offline
- Elite Member
2 weeks 2 days ago - 2 weeks 2 days ago #8
by Franz Frese
Replied by Franz Frese on topic Historic events: visibility
Last edit: 2 weeks 2 days ago by Franz Frese.
Please Log in or Create an account to join the conversation.
- hermann
- Offline
- Elite Member
2 weeks 2 days ago #9
by hermann
Hermann
Designer of the custom module "Extended Family"
webtrees 2.1.22 (all custom modules installed, PHP 8.3.12, MariaDB 10.6) @ ahnen.hartenthaler.eu
Replied by hermann on topic Historic events: visibility
I support Franz and Sir Peter. The way it is implemented now is a bug, not a feature. The string "English King" can be translated easily into many languages and then this module can be used for many more user languages than only the English-speaking webtrees users. It would be different in modules which provide many long text descriptions in one language only, but even then: let the user decide to use a translation function in his browser or to switch off the historic data.
In my opinion, the parameter "language" is helpful if you offer links to Wikipedia for example in a historical data module. Then you can search in wikidata which Wikipedia offers an appropriate article in the language of the user.
In my opinion, the parameter "language" is helpful if you offer links to Wikipedia for example in a historical data module. Then you can search in wikidata which Wikipedia offers an appropriate article in the language of the user.
Hermann
Designer of the custom module "Extended Family"
webtrees 2.1.22 (all custom modules installed, PHP 8.3.12, MariaDB 10.6) @ ahnen.hartenthaler.eu
Please Log in or Create an account to join the conversation.