Web based family history software

Question webtrees global message module

  • HerzScheisse
  • Topic Author
  • Offline
  • New Member
  • New Member
More
1 month 5 days ago - 1 month 5 days ago #1 by HerzScheisse
webtrees global message module was created by HerzScheisse
Hey,

It took me a while but i finally published my first custom module of webtrees...

This add a notice/flash message to each page, if the user is not logged in and that the display data is limited...

Screenshots:


the repo can be found here github.com/HerzScheisse/wtGlobalMessage

Since this is my first module and thing may be better implemented any suggestion or PR is welcome...

cheers

webtrees 2.1.20 - modules: all vesta, faces, legal notice, privacy policy, fancy treeview, fancy research links
Linux Ubuntu | PHP 8.3.3 | MariaDB 10.5.23 | rewrite_urls="1"
Last edit: 1 month 5 days ago by HerzScheisse.

Please Log in or Create an account to join the conversation.

More
1 month 4 days ago #2 by RickM
Replied by RickM on topic webtrees global message module
Wow,

Thank You for your efforts..

I will check this out for sure..

Rick M
Tauranga
New Zealand - Nu Tirani

alineofmalkins.com/wt-malkins
Webtrees v2.1.20
Hosted by HostAmarada on litespeed Server, PHP v8.2

Please Log in or Create an account to join the conversation.

  • bertkoor
  • Offline
  • Platinum Member
  • Platinum Member
  • Greetings from Utrecht, Holland
More
1 month 4 days ago #3 by bertkoor
Replied by bertkoor on topic webtrees global message module
I don't know where to begin with critique, but I also don't want to temper your enthusiasm.

Functionality:
  • The displayed message (please log in) is in conflict with your terms of service (you need to be a family member). A large portion of your visitors thus gets an annoying error banner on each page, but there is no way for them to let it go away.
  • When switching language the translation is not re-evaluated, until the page is refreshed.
  • The error banner seems to be shown always on each page for visitors, even when all displayed data is public. An example is the login page. I don't like computer programs telling me a lie.
  • A more discrete place for the message would be at the bottom of the page instead of the top. That might not be your fault, since the work is done in function getFooter.

Technical:
  • I think the example module shows a better (extendable) way of handling translations than via .po / .mo files. In your implementation it is mandatory to do it via such files and users cannot do it in the generic way.
  • When I fetch the url given by function customModuleLatestVersionUrl by hand, I get a 404-NotFound response.
  • Naming things is hard. Really hard. I think there must be a better name for the message than 'Global Message Text'.

But other than all that, it seems to work. So congratulations!

stamboom.BertKoor.nl runs on webtrees v2.1.20

Please Log in or Create an account to join the conversation.

More
1 month 3 days ago #4 by xiao
Replied by xiao on topic webtrees global message module

Hey,

It took me a while but i finally published my first custom module of webtrees...

This add a notice/flash message to each page, if the user is not logged in and that the display data is limited...

Screenshots:


the repo can be found here github.com/HerzScheisse/wtGlobalMessage

Since this is my first module and thing may be better implemented any suggestion or PR is welcome...

cheers
Thank you very much for your effort, I will try it now.

Please Log in or Create an account to join the conversation.

More
1 month 3 days ago #5 by xiao
Replied by xiao on topic webtrees global message module
After testing, the above problems will occur when not logged in.
 

Please Log in or Create an account to join the conversation.

  • bertkoor
  • Offline
  • Platinum Member
  • Platinum Member
  • Greetings from Utrecht, Holland
More
1 month 3 days ago #6 by bertkoor
Replied by bertkoor on topic webtrees global message module
Yeah, this module has severe issues when running in other languages than (British) English and German me thinks.

stamboom.BertKoor.nl runs on webtrees v2.1.20

Please Log in or Create an account to join the conversation.

More
1 month 1 day ago #7 by Franz Frese
Replied by Franz Frese on topic webtrees global message module
  xiao  is using a webtrees version, that is not uptodate!

Please Log in or Create an account to join the conversation.

  • HerzScheisse
  • Topic Author
  • Offline
  • New Member
  • New Member
More
3 weeks 6 days ago #8 by HerzScheisse
Replied by HerzScheisse on topic webtrees global message module
Thanks for the feedback guys... and sorry for the late reply... if been very busy the last days...

I don't know where to begin with critique, but I also don't want to temper your enthusiasm.
 
Thank you for your critique... since this is my first module i really appreciate it and dont take this personal... so dont worry...

I will address some issues and will come up with a fix...

 

webtrees 2.1.20 - modules: all vesta, faces, legal notice, privacy policy, fancy treeview, fancy research links
Linux Ubuntu | PHP 8.3.3 | MariaDB 10.5.23 | rewrite_urls="1"

Please Log in or Create an account to join the conversation.

Powered by Kunena Forum