Question Primer theme

ekdahl
Topic Author
Offline
New Member

3 months 5 days ago #1 by ekdahl

Primer theme was created by ekdahl

I've been working on a theme based on the Primer (Github) design. This has previously been discussed in this thread, but now I feel it's mature enough for a first release. The theme has been renamed before its first release to Primer instead of GitHub.

If you want to see it in action, my website can serve as a demo for the theme, here .
The GitHub repository where the release can be found is here . Issues can also be reported there (or in this thread).

Please Log in or Create an account to join the conversation.

Franz Frese
Offline
Elite Member

3 months 5 days ago - 3 months 5 days ago #2 by Franz Frese

Replied by Franz Frese on topic Primer theme

fine!
Shouldn't the top color of "light high contrast" be changed as like as the sub-windows heading?

the module GVExport doesn't look good (isn't)readable for some palettes.

For to get help, tell the address of your webtrees site!
mine is: freris.de

Last edit: 3 months 5 days ago by Franz Frese.

Please Log in or Create an account to join the conversation.

ekdahl
Topic Author
Offline
New Member

3 months 5 days ago #3 by ekdahl

Replied by ekdahl on topic Primer theme

Can you show what you mean with an image (and how it differs from the same palette on GitHub), because I don't understand how you mean?
I've never heard of GVExport, but maybe I will take a look. PRs are welcome with fixes for that module.

Please Log in or Create an account to join the conversation.

Franz Frese
Offline
Elite Member

3 months 5 days ago - 3 months 5 days ago #4 by Franz Frese

Replied by Franz Frese on topic Primer theme

Seems as if images can not be uploaded (this time). I send the example as github issue:
github.com/ekdahl/webtrees-primer-theme/issues/15

For to get help, tell the address of your webtrees site!
mine is: freris.de

Last edit: 3 months 5 days ago by Franz Frese.

Please Log in or Create an account to join the conversation.

RickM
Offline
Junior Member

3 months 5 days ago #5 by RickM

Replied by RickM on topic Primer theme

Thank You for your efforts..

I'm not sure it is the Theme for me, however well done..

Rick M
Tauranga
Nu Tirani - New Zealand

alineofmalkins.com/wt-malkins
Webtrees v2.2.2
Hosted by HostAmarada on litespeed Server, PHP v8.3

Please Log in or Create an account to join the conversation.

ekdahl
Topic Author
Offline
New Member

3 months 4 days ago #6 by ekdahl

Replied by ekdahl on topic Primer theme

Franz Frese wrote:
the module GVExport doesn't look good (isn't)readable for some palettes.

I tested GVExport, and I think the main problem is that the module is using some hardcoded colors instead of the available CSS variables, which causes some UI elements to look strange. See e.g. here .
I did some fixes related to buttons for this though, so should be a bit better now, but the main issue is the hardcoded white background in the module.

Please Log in or Create an account to join the conversation.

Mperates
Offline
New Member

3 months 4 days ago #7 by Mperates

Replied by Mperates on topic Primer theme

Franz has raised this to my attention. It's definitely a GVExport issue, I'll look at this for the next release.

Please Log in or Create an account to join the conversation.

RickM
Offline
Junior Member

3 months 3 days ago #8 by RickM

Replied by RickM on topic Primer theme

If the issue is hard coded css,
example <div class="abc" style="color:red;"> Example html styled inline</div>

Then perhaps all that is needed is an override of class abc in the css file
example .abc { color: blue!important;}

This would be one of the few times using the !important attribute in css would be acceptable..

Just my thoughts!!!

Rick M
Tauranga
Nu Tirani - New Zealand

alineofmalkins.com/wt-malkins
Webtrees v2.2.2
Hosted by HostAmarada on litespeed Server, PHP v8.3

Please Log in or Create an account to join the conversation.

ekdahl
Topic Author
Offline
New Member

3 months 3 days ago #9 by ekdahl

Replied by ekdahl on topic Primer theme

Yes, I'm aware of that. But I don't want a situation where themes need to have special code to override hardcoded styles for loads of custom modules. I prefer having "proper" fixes, so themes can contain a more general set of styles.

Please Log in or Create an account to join the conversation.

RickM
Offline
Junior Member

3 months 3 days ago #10 by RickM

Replied by RickM on topic Primer theme

I was going to mention the hard way.. And I do understand completely.. Hence me saying 'it was one of the few times'..

I appreciate your attention to the detail.. That !important attribute has been a bain in my life.. I have known some folk who have overridden !important css with more because they cannot find where the change was made..
Anyways, good for you for looking to find the correct solution..

Rick M
Tauranga
Nu Tirani - New Zealand

alineofmalkins.com/wt-malkins
Webtrees v2.2.2
Hosted by HostAmarada on litespeed Server, PHP v8.3

Please Log in or Create an account to join the conversation.

Mperates
Offline
New Member

3 months 3 days ago #11 by Mperates

Replied by Mperates on topic Primer theme

I have today made many changes to how GVExport handles styling. It might not be perfect but it now works much nicer on all the themes I tested, including Primer.

I haven't published a release yet as I have other work to go into it, but if anyone wants to test the "main" branch the changes have been applied there and it should be stable. Let me know here or in an issue on Github if there are further oddities, I'm happy to look into issues with any theme. GVExport has been around for quite some time and maintained by a number of different people, it will definitely have it's quirks!

By the way, this Primer theme looks great!

Please Log in or Create an account to join the conversation.

HerzScheisse
Offline
New Member

3 months 3 days ago #12 by HerzScheisse

Replied by HerzScheisse on topic Primer theme

Thanks for your module and the fast fixes @Mperates
Will test GVExport the next days...

Yeah i really like the new Primer theme... been working with this for a couple of weeks now... and wont miss it anymore

webtrees 2.1.20 - modules: all vesta, faces, legal notice, privacy policy, fancy treeview, fancy research links
Linux Ubuntu | PHP 8.3.3 | MariaDB 10.5.23 | rewrite_urls="1"
My genealogy site: www.eisold.family

Please Log in or Create an account to join the conversation.

Mperates
Offline
New Member

3 months 2 days ago - 3 months 2 days ago #13 by Mperates

Replied by Mperates on topic Primer theme

HerzScheisse wrote:
Thanks for your module and the fast fixes @Mperates

Not a problem! I can't take too much credit though, this module has been around for a very long time, since before webtrees was forked from PhpGedView (it was a PhpGedView module). I'm just the latest in a very long line of people who have been caring for it!

Last edit: 3 months 2 days ago by Mperates.

Please Log in or Create an account to join the conversation.

ekdahl
Topic Author
Offline
New Member

2 months 4 weeks ago - 2 months 4 weeks ago #14 by ekdahl

Replied by ekdahl on topic Primer theme

Thanks for the quick feedback Mperates.

I've published a new release now, with some fixes and additions. Here: github.com/ekdahl/webtrees-primer-theme/releases/tag/1.1.0

Attachments:

Last edit: 2 months 4 weeks ago by ekdahl.

Please Log in or Create an account to join the conversation.

Franz Frese
Offline
Elite Member

2 months 4 weeks ago #15 by Franz Frese

Replied by Franz Frese on topic Primer theme

hi, thx, but you forgot to update:
public const CUSTOM_VERSION = '1.0.0';

For to get help, tell the address of your webtrees site!
mine is: freris.de

Please Log in or Create an account to join the conversation.

ekdahl
Topic Author
Offline
New Member

2 months 4 weeks ago #16 by ekdahl

Replied by ekdahl on topic Primer theme

Oh, thanks. Updated that now.

Please Log in or Create an account to join the conversation.

brozer
Offline
New Member

4 weeks 12 hours ago #17 by brozer

Replied by brozer on topic Primer theme

Un grand merci, ce thème est magnifique !

Please Log in or Create an account to join the conversation.

doubet
Offline
New Member

2 weeks 4 days ago #18 by doubet

Replied by doubet on topic Primer theme

Thank you. I was looking for a "darker" theme that wouldn't make my eyes bleed at night. Excellent work.

Please Log in or Create an account to join the conversation.

Yuk
Offline
New Member

2 weeks 2 days ago #19 by Yuk

Replied by Yuk on topic Primer theme

Beautiful theme! Thank you so much for sharing this!

Please Log in or Create an account to join the conversation.

ekdahl
Topic Author
Offline
New Member

2 weeks 2 days ago #20 by ekdahl

Replied by ekdahl on topic Primer theme

Thanks for the appreciation!
A new release has just been posted here: github.com/ekdahl/webtrees-primer-theme/releases/tag/1.2.0

Please Log in or Create an account to join the conversation.