Question own favicons

Wt has no automatism to have your own favicons. 
If you have those, put it in a task to do after release of a new version.
Most of the wt site owners won't change these icons.
If you want: put it in a daily cron job and you nearly always have, what you want.
Why should there be created something, that nearly nobody uses.

I think you under-estimate the demand, Franz. I toyed with the same idea and came up with less elegant solutions. This should be easy to do without technical knowledge.

For each person asking something, there are about ten beeing silent with the same wish.

Now search the forum & github issues for 'favicon'.

jopla wrote:

My idea was to make my own favicons with "chmod -w" write protected. Would that work or will the update be in the soup?

We were running a bit off topic. But to answer my own question above, I 've done a little test. 

The test:
I installed a test version of v2.2.4. I replaced the favicons in the root and the /public/ for my own and made the write protected with chmod -wx.

After it I tried to update to 2.2.6. But the update crashed and was complete blocked. 

Conclusion:
Maybe there was another reason for the crash, but it seems that this method does not work.

Update:
I was doing another test with updating from 2.2.4 -> 2.2.6 and it got the same error:  
So my conclusion was too premature.
 

>Uncaught Error: Call to undefined method Fisharebest\Webtrees\Tree::rowMapper()
I assume that you downgraded webtrees. That is a complicated thing you should not do. I assume that the error is the result of that erroneous downgrading and not a result of your chmod action.

hermann wrote:

>Uncaught Error: Call to undefined method Fisharebest\Webtrees\Tree::rowMapper()
I assume that you downgraded webtrees. That is a complicated thing you should not do. I assume that the error is the result of that erroneous downgrading and not a result of your chmod action.

I didn't downgrade my webtrees installation. I made a new and fresh 2.2.4 installation.

New TEST
I've done a new test:

1. new fresh installation of webtrees 2.2.5
2. I made the favicons en apple-touch-icon in the "/" and the "/public" write-protected with "chmod -xw ...". 
3. click to update to 2.2.6

De update is running but finally stopped, because it can NOT copy the apple-touch-icon.png.

Conclusion
It is NOT possible to block the own favicons from updating by making write-protected.

Extra TEST
This test is more for myself, but maybe somebody else can use it also: 

1. new fresh installation of webtrees 2.2.5
2. I made a folder "assets/my-favicons" in "/public"
3. I copy my own favicons to "/public/assets/my-favicons"
4. click to update to 2.2.6

After the update the new folder with my favicons still exists.

Idea's are welcome
 

I made a first beta release for a module. If somebody is interested to test, please send me a message.

If it works then it works. Will try later with some different versions of webtrees.

Since I don't have a codeberg account yet, I'll make a comment here. One thing caught my eye:


Firstly, I'd try to avoid using emoticons in code. They might not get decoded properly.
Comments are always about stuff around it, you do not need to point at it.

Then, who / what will ever call the function getInstance? Where does that come from? I think it can be safely removed.

I got in the control panel an error: Method getAdminAction() not found in _webtrees-customfavicons_

btw: if you use I18N then you should use American English strings as base.

@bertkoor, @hermann
Thanks for the feedback.

For this moment I m working for another idea to use the own favicons, less depending to the implantation in Webtrees. That seems to work fine.
 

you mean "implementation". tell us. Let's not die ignorant.