Question Missing data

sevtor wrote:

Do you know what to do? Thanks!

i did some little research on this and i guess we have to tell WT to use our own module translation file...

I found this part in a module GVExport

But i cant get it to work... but maybe its a little help for you...

EDIT...

I Got it to work... will provide a PR soon...

we need to include "use Fisharebest\Localization\Translation;"

PR done...

github.com/sevtor/modules/pull/3

Franz Frese wrote:

delete the php - file and it is auto recreated
 

That is OK if one has a development version of webtrees, but when we have installed webtrees from download link there is no messages.po file so the messages.php file cannot be recreated.

You are right.

I received the update of the different module.php files but unfortunately the translations are added too late! When the 'Reports' option is clicked and a report is selected the title and description fields are not yet translated. But when the report is actually generated all translations are there.

Therefore I found that a much better solution is to modify ModuleCustomTrait.php. It is included in the updated archives new-reports-2.1.x.zip and new-reports-2.1.x.zip. As before the files in there is intended to the corresponding files in your webtrees installation. Still hoping for these updates to be included in a coming release!

The new modules are updated and unfortunately the translations to de and nl need a minor adjustment.

Hey sevtor,

thanks for you work on this again...

no worries about the late translations, i can update them again... i'm very happy with that updated any extra reports you've done...

first i need to know, you reverted my proposed change from "LANG_CODE/messages.po" to "LANG_CODE.po"
Is there a reason for that? I've checked a couple of modules and most modules use the later structure...

If you agree with that, i can propose another PR...

 

HerzScheisse wrote:

Hey sevtor,

first i need to know, you reverted my proposed change from "LANG_CODE/messages.po" to "LANG_CODE.po"
Is there a reason for that? I've checked a couple of modules and most modules use the later structure...




 

OK, I should have explained this better but it was very late yesterday!
During my experiments with different solutions I found that the function customTranslations(string $language) in the module is called too late. The title() and description() functions of the module are called before the translations are included. The presentation of the report when clicking on the 'Reports' menu item presents the alternatives with their English names, and when one option is selected the title and description are in English. But when a report is selected the translations are activated before the report is generated.

However, I wanted the translated phrases to be used all the time. You can see that the title is supposed to be I18N::translate('...').
This is achieved by the modification in app/Module/ModuleCustomTrait.php ! All modules should have the same structure and LANG_CODE/messages.* is used in many places. In order to speed up the translation phase the messages.po files (or messages.mo) are converted to messages.php and saved to be used the next time.
Maybe I should also test the other naming convention.

Btw, it is necessary that the .po files have exactly one space character between msgid and the string (same for all msg...).

I think your change of the ModuleConfigTrait is not wanted. Instead you should use a class, that uses the trait.

There are about 20 modules/classes that use ModuleConfigTrait in webtrees.

Yes, I understand that this module is needed by many other modules.
But this change is totally compatible and just adds translations to a module that have a messages.po file but not a messages.php file so I really hope that it is OK.
A module can already have a function customTranslations(string $language) but it is called after the calls to title() and description() of the module which means that the title and description are not translated when clicking on 'Reports'. If I could find these calls instead I could change there but that would also be somewhere in the core.

Unfortunately I messed up the translation files the other day, I am sorry for the inconvenience it ma have caused.
Here is a new zip archive with correct translation for Swedish. The German and Dutch translations need checking. There are also messages.pot files that can be used when updating ("msgmerge .../nl/messages.po .../messages.pot")
All modules should have the customTranslation function is included, added now.

no worries... we all learn something new on webtrees... and i must say, what you've achieved so far is awesome...

just a qucik side note/question...
why did you use the folder structure for languages again?

from my understanding it would be better to store all LANG.po files in the "lang" folder... add the messages.pot file there

Thanks. Well, about how to store the translation files I just looked at the webtrees/resources/lang/ folder and thought that it should be the same structure. I also remembered that the locale folder in Unix have LANG_CODE folders, but that is not really compatible. And when I modified the ModuleCustomTrait.php file I used similar code as already existed for the main messages.php generation.
Yes, I stored the messages.pot file in the lang folder.

Now, after a few days of reflection, I regret that I changed back to my original design, but it would be easy to adapt the modification to the other model.
I have checked other modules that are published and both structures are used, so my conclusion is to stay with separate folders.
 

Updated version of the zip files, new-reports-2.1.x.zip for webtrees 2.1.x and new-reports-2.2.x.zip for webtrees 2.2.x
 

Updated once again: removed conversion of first character in gedcom records for German language.
Moved interpretation of tag _SP_DEAT to app/Report and xml reports, i.e. app/Gedcom.php not changed.
Only one zip archive for reports, works with both versions 2.1.x and 2.2.x.

the marriage report pdf-output looks destroyed.

You are right, the old report definitions need some minor adjustments. I think I have made the necessary changes to all xml files now. The pedigree_report.xml should be replaced by family_tree_report.xml and the ahnentafel_report.xml and descendancy_report.xml should be replaced by family_history_report.xml which information but with possibility to select more options.

The standard reports are included in the new new-reports.zip archive and some minor changes are done in new_modules.zip, both attached here.

You should deploy a messages.po in your modules_v4 subdir, but not the php-file.

Franz Frese wrote:

You should deploy a messages.po in your modules_v4 subdir, but not the php-file.
 

Yes, but there are no messages.php files in the latest new-modules.zip and not if they are downloaded from github.com/sevtor/modules so I suspect that you have an old version, or did not clean-out the old files before extracting the new archive. By mistake some early versions had .php files!

Any Intel if/when this will be an integration in core?