Question add stories

Peter_S
Offline
Senior Member

1 month 1 day ago #21 by Peter_S

Replied by Peter_S on topic add stories

SteveGermany wrote:
Another issue is the language problem. How would we handle the language issue in notes?

With GEDCOM 7.x it is possible to maintain notes depending on the language.

Example — The following presents the same note in HTML-format English; in plain-text with the same language as the superstructure (English); and in Spanish with the same media type as the superstructure (HTML).

Code:

NAME Arete /Hernandez/
NOTE Named after Arete from <i>The Odyssey</i>
LANG en
MIME text/html
TRAN Named after Arete from "The Odyssey"
MIME text/plain
TRAN Nombrada en honor a Arete de <i>La Odisea</i>
LANG es

Peter

webtrees 2.2.1, vesta modules, chart modules of magicsunday, extended family and imprint of hartenthaler
PHP 8.3.12, MariaDB 10.11.8
Webhosting: genonline.de

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

1 month 20 hours ago #22 by SteveGermany

Replied by SteveGermany on topic add stories

very interesting. I assume it would need some changes to the program to accommodate this feature.

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.

bertkoor
Offline
Platinum Member
Greetings from Utrecht, Holland

1 month 16 hours ago - 1 month 16 hours ago #23 by bertkoor

Replied by bertkoor on topic add stories

"Some changes" is an understatement . I'm not sure how far the coding for support of Gedcom v7 is, but it's a giant task.

I think it's easier to make a small change so editors can do what administrators can do with stories on an individuals page.

No guarantees (I have not tested this) but you can try this tweak in app/Modules/StoryModule.php, around line 99 (which was line 102 at time of release of v2.2.1):

Code:

'is_admin' => Auth::isEditor($individual->tree()),

stamboom.BertKoor.nl runs on webtrees v2.2.1

Last edit: 1 month 16 hours ago by bertkoor.

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

1 month 15 hours ago #24 by SteveGermany

Replied by SteveGermany on topic add stories

That was quick! Thanks.
I get the Edit link now but it goes onto a page with: "Admin only action"

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.

bertkoor
Offline
Platinum Member
Greetings from Utrecht, Holland

1 month 15 hours ago - 1 month 15 hours ago #25 by bertkoor

Replied by bertkoor on topic add stories

That error is thrown in ModuleAction.php:

Code:

Actions with "Admin" in the name are for administrators only.

So this can be ~~solved~~ bypassed by an edit in resources/views/modules/stories/edit.phtml, line 28.
Change 'action' => 'AdminEdit' to 'action' => 'Edit'

NB, this also occurs (twice) in resources/views/modules/stories/tab.phtml

stamboom.BertKoor.nl runs on webtrees v2.2.1

Last edit: 1 month 15 hours ago by bertkoor.

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

1 month 15 hours ago #26 by SteveGermany

Replied by SteveGermany on topic add stories

Now I get: Method getEditAction() not found in stories

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.

bertkoor
Offline
Platinum Member
Greetings from Utrecht, Holland

1 month 14 hours ago #27 by bertkoor

Replied by bertkoor on topic add stories

Then in the StoriesModule.php rename the public function getAdminEditAction (should be on line 269) to getEditAction, and rename function postAdminEditAction (should be on line 315) to postEditAction.

We can continue like this until it finally works ;-)

stamboom.BertKoor.nl runs on webtrees v2.2.1

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

1 month 7 hours ago #28 by SteveGermany

Replied by SteveGermany on topic add stories

Brilliant! It works. Sorry for the delay - I had to go out.
Thank you so much for doing this.
I think this is a great app and I hope you feel motivated to put some more of your ideas into it at some point.
Steve

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.

kiwi
Offline
Platinum Member

1 month 7 hours ago #29 by kiwi

Replied by kiwi on topic add stories

Don’t forget to repeat those changes each time you upgrade webtrees.

Nigel
www.our-families.info

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

4 weeks 1 day ago #30 by SteveGermany

Replied by SteveGermany on topic add stories

Good point Nigel.
Will it become a standard change in future or even make it possible to choose the editing level in the control panel (or even use the set permissions)?

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.

kiwi
Offline
Platinum Member

4 weeks 1 day ago #31 by kiwi

Replied by kiwi on topic add stories

SteveGermany wrote:
Good point Nigel.
Will it become a standard change in future or even make it possible to choose the editing level in the control panel (or even use the set permissions)?

If your question is meant for me, I have no idea. I’m not involved in webtrees development. But personally I wouldn’t be in favour.

Nigel
www.our-families.info

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

4 weeks 1 day ago #32 by SteveGermany

Replied by SteveGermany on topic add stories

Hi Nigel
Just found a bug:
When I try to edit control panel - modules I get:
Method getAdminEditAction() not found in stories

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.

bertkoor
Offline
Platinum Member
Greetings from Utrecht, Holland

4 weeks 1 day ago - 4 weeks 1 day ago #33 by bertkoor

Replied by bertkoor on topic add stories

Not a bug, result of our tweaks.
Remember I asked you to rename the AdminEdit methods? The control panel wants them back.

Copying the methods would have been better. Or getEdit calling getAdminEdit and postEdit callinf postAdminEdit.

stamboom.BertKoor.nl runs on webtrees v2.2.1

Last edit: 4 weeks 1 day ago by bertkoor.

Please Log in or Create an account to join the conversation.

SteveGermany
Offline
New Member

4 weeks 20 hours ago #34 by SteveGermany

Replied by SteveGermany on topic add stories

Yes, I assumed it was something like that - not a bug in the original program of course. Remember, I'm not a programmer and I haven't a clue how this all works.

Steve Engelking
Simon Heinrich Sack'sche Familienstiftung
Webtrees 2.2.1

Please Log in or Create an account to join the conversation.