Question Header and footer on PDF reports

If I Recall Correctly, one of the issues with fonts and PDF was that only a small set of fonts are open source (or can be used in open source software) and others may violate their use statements.  I don't remember the discussion that was had years ago about fonts in these reports but please look into this before including them in the code to be distributed!

Just do a pull request ...
It looks as if I need git (which I have but not used), composer and npm, and then clone the entire webtrees??
Well, I have been programming for 60 years now, and that looks as too much work. app/report does not follow all white-space rules but works. I can test the other reports, provide info on translations that are needed. How to add own modules? I can't find information about that.

Softwareentwicklung in einer lockeren Gruppe (als public domain) ist ohne github (oder ähnlichem) nicht sinnvoll, also versuche es darüber oder versuche jemanden zu finden, der es für dich macht.

Sind deine Änderungen am webtrees code kompatibel mit den Standard reports?
Sind dort häufige Änderungen zu erwarten? Warum wurden sie durchgeführt bzw was bewirken sie?

---

Software development in a loose group (as public domain) doesn't make sense without github (or similar), so try doing it through it or try to find someone to do it for you.

Are your changes to the webtrees code compatible with the standard reports?
Are there frequent changes to be expected? Why were they carried out or what do they achieve?

---

ps: the link in your footer of this forum goes to https, but that does not work well. There you must use torstendahl.se/demo to show correct or you do the necessary changes for https to work correctly.

for example
you changed PdfRenderer.php, but but that is not used in your modules.

So, if that is a correction for the existing module: describe the change, perhaps the issue number that is corrected with that change.

Then that can simply be uploaded as pull request.
 

I just a quick check of the code and state following:
the modules family-history and family-individuals do use a changed ReportParserGenerate.
the module descendants-overview and  family-tree use the changed ReportParserGenerate indirectly.
So for the other changed webtrees Report Code, you could explain, what it does better than the original code. (so a pull request could be done for each of these files).
Perhaps you can help with a description or something else.
 

I am working on this but other duties intervened.
1. testing other reports
2. "beautfying" the code
3. describing changes and why they are introduced
I have a clone of webtrees and will try to make a pull request later!

sevtor wrote:

I am working on this but other duties intervened.
1. testing other reports
2. "beautfying" the code
3. describing changes and why they are introduced
I have a clone of webtrees and will try to make a pull request later!

Looking forward to your work

I have now after an intensive training week managed to create a pull request for app/Report!
It remains to submit the new report modules but I think that is easier.
There is also a need to create translations. I have a translation file for Swedish but it should be created with Weblate and that requires that the phrases to translate are extracted which I guess will be done when the pull request is accepted.

Now I have spent many hours to create a pull request. I have a fork of webtrees and there created a branch where the modified code is checked in. When I push code there some checks are run automatically. But now I have no clue on how to proceed!
The phpstan check says that an error is ignored but still reports it as an error which prevents the PR from being forwarded to review. And the resuilts from checks for php 8.4 are not understandable to me.
The code that stops php 8.1 - 8.3 has been there as long as I know.
Please help me! I don't understand how to proceed from here...

Do not create a branch. Change the Original on your Computer, then push and commit. Ignore the check results. Greg will handle.

Thanks! I will now make another try.
In my profile I have given torstendahl.se/demo/ where I have most of the new features. When used the address is changed to use https instead. My "real" site is torstendahl.se/webtrees but there I require login.

I can see the pull request:
github.com/fisharebest/webtrees/pull/4945

And the file that's giving issues:
github.com/fisharebest/webtrees/pull/494...8591f93bec8de82fb3e4

It looks like a static code analyser found a bit more findings than in the previous version.
Just let Greg handle that

But do I have to do anything more to trigger Greg to handle it, or will he pick up the pull request automatically?

Greg seems to be a very busy man lately. Sometimes life takes precedence over the hobby project.

Maybe you can grab his attention by creating an issue , referencing the PR and the issue by links back & forth.

Thanks! I will consider that but I understand if he must give priority to other things.