Question v2.0.17 - Things that no longer work after update

After the update to v2.0.17, besides the missing line breaks (see www.webtrees.net/index.php/en/forum/help...ts-text-under-source ), two things no longer work when displaying sources:

- Links in the source citation details are not formatted correctly -> the link and any additional text are displayed together as a link.

- Markdown formatting in the source text is not displayed formatted

I didn't see much modification.
The only thing I noticed was the loss of my translations but I had already been warned here on the forum about this.

Same issue on my side 
Line break doesn't work any more in Text

It is planned to fix the Line Break issue in "Text"  ?

Oupss..  www.webtrees.net/index.php/en/forum/help...ts-text-under-source
 

See github.com/fisharebest/webtrees/issues/4084

mp wrote:

After the update to v2.0.17, besides the missing line breaks (see www.webtrees.net/index.php/en/forum/help...ts-text-under-source ), two things no longer work when displaying sources:

- Links in the source citation details are not formatted correctly -> the link and any additional text are displayed together as a link.

- Markdown formatting in the source text is not displayed formatted

Same here. Furthermore

- tables

- bold characters

don't work anymore.

I already reported the same issue in the thread www.webtrees.net/index.php/en/forum/help...ts-text-under-source 1 month 1 week ago.
@fisharebest had pointed to the issue github.com/fisharebest/webtrees/issues/4056 as being reported already.
As to me the issue #4056 has been closed (probably means it is fixed) but the issue we talk about here is not fixed.
I am checking with webtrees demo latest beta (2.1.0-dev).
I plead the developers for fixing the issue.

Can anyone tell which folder the old images go to after the update - icon and logo

Alguém sabe dizer pra qual pastas vão as imagens antigas após a atualização? ícones e logos

> As to me the issue #4056 has been closed (probably means it is fixed) but the issue we talk about here is not fixed.

Which issue exactly?

As far as I can tell, the two issues in post #1 are fixed in both the 2.1-dev and 2.0-dev branches of the code.

As far as I can tell, the two issues in post #1 are fixed in both the 2.1-dev and 2.0-dev branches of the code.

Thanks a lot, that is true. Links with additional text and markdown formatted text work again in v2.1 (v2.0-dev could not be tested).

But line breaks in text (CONT) still do not work.

> But line breaks in texts (CONT) still do not work.

The markdown specification says that

* lines of text should be joined together to create one paragraph
* to create a new paragraph, use two line-breaks
* to force a line-break, add two spaces to the end of the previous line.

But we have Gedcom-tags like CONT for a new line too. It seems that Markdown overwrites the Gedcom structure.

In my opinion the CONT tag should interpreted first as a new line (similar to <br>). For <p> it is clear to use two line breaks.

The problem (my problem) is, that I have a lot of source citations, shared note and inline notes copied from sources using CONT structure. Later I added markdown for bold, italic, links etc. I can‘t format all of them with Markdown again for correct linebreaks now only because the interpretation has been changed.

@fisharebest: Which issue exactly?

The issue described and documented in the first post of this thread and in the first post of thread www.webtrees.net/index.php/en/forum/help...ts-text-under-source .

@mp says: In my opinion the CONT tag should interpreted first as a new line (similar to <br>). For <p> it is clear to use two line breaks.

The problem (my problem) is, that I have a lot of source citations, shared note and inline notes copied from sources using CONT structure. Later I added markdown for bold, italic, links etc. I can‘t format all of them with Markdown again for correct linebreaks now only because the interpretation has been changed.

The same with me. I have several thousands of source citations where in text field there are transcriptions of the source documents.

mp wrote:

But we have Gedcom-tags like CONT for a new line too. It seems that Markdown overwrites the Gedcom structure.

In my opinion the CONT tag should interpreted first as a new line (similar to <br>). For <p> it is clear to use two line breaks.

The problem (my problem) is, that I have a lot of source citations, shared note and inline notes copied from sources using CONT structure. Later I added markdown for bold, italic, links etc. I can‘t format all of them with Markdown again for correct linebreaks now only because the interpretation has been changed.

I totally agree with that.

How about tables?
Do we have to add some additional characters or new lines etc., too?

fisharebest highlighted

fisharebest wrote:

>the two issues in post #1 are fixed in both the 2.1-dev and 2.0-dev branches of the code.

I'm not able to test both of these 2 versions
So I'm waiting the next official release which will fix the issue

The display of tag TEXT within tag SOUR in Facts and events tab does not respect newlines (i.e. CONT tags):

Klugesherz wrote:

I'm not able to test both of these 2 versions
So I'm waiting the next official release which will fix the issue
The display of tag TEXT within tag SOUR in Facts and events tab does not respect newlines (i.e. CONT tags):

But, it was working properly until 2.0.16 ! What was changed here? That's really annoying.

If I understand Greg correctly then behaviour depends on the tree setting whether Markdown Formatting is enabled.

When Markdown formatting is disabled, then CONT tags should mean a new line.
When enabled, then Markdown rules apply: lines are concatenated as paragraphs, and two new lines needed for a new paragraph.

Could you check this please?

bertkoor wrote:

If I understand Greg correctly then behaviour depends on the tree setting whether Markdown Formatting is enabled.

When Markdown formatting is disabled, then CONT tags should mean a new line.
When enabled, then Markdown rules apply: lines are concatenated as paragraphs, and two new lines needed for a new paragraph.

Could you check this please?

Correct.

In "markdown" mode, we apply markdown formatting. Markdown requires to line-breaks to create a new paragraph and two spaces to create a new line.

In "text" mode, we keep the line-breaks.

But, if you want "almost markdown", then a simple CSS change should give you what you want:

Parameter has been set as "NO Markdown"



But I guess that I have still the issue because I'm on the official release : v2.0.17