Web based family history software

file Question v2.0.17 - Things that no longer work after update

More
3 years 2 months ago - 3 years 2 months ago #41 by Klugesherz
Replied by Klugesherz on topic v2.0.17 - Things that no longer work after update
:-( :-( :-(
No body wants to consider my message.

What about to the proposal to separate the 2 parameters.
1 parameter to decide Markdown for "Note"
1 parameter to decide Markdown for "Text" (Sources)


To avoid the big Job of Bogie it would be so helpful

Based on the fact that for the former version of webtrees 2.0.16 --> only "Notes" supported markdown

Merci ;-)

webtrees 2.1.x---> My famility tree
PHP 8.0
Last edit: 3 years 2 months ago by Klugesherz.

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #42 by drblam

:-( :-( :-(
Based on the fact that for the former version of webtrees 2.0.16 --> only "Notes" supported markdown
Merci ;-)

Actually, I'm still running webtrees 2.0.16 right now, and I can assure you that Markdown works for Text (Sources) here too.

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #43 by hermann
@Klugesherz: I think your idea can be good, but it is too early to think about it. For me, it is not clear what is a bug and what is a feature. As soon as there are no more bugs, I can think about your suggestion.

Hermann
Designer of the custom module "Extended Family"

webtrees 2.1.22 (all custom modules installed, PHP 8.3.12, MariaDB 10.6) @ ahnen.hartenthaler.eu

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #44 by rola

:-( :-( :-(
No body wants to consider my message.

What about to the proposal to separate the 2 parameters.
1 parameter to decide Markdown for "Note"
1 parameter to decide Markdown for "Text" (Sources)


To avoid the big Job of Bogie it would be so helpful

Based on the fact that for the former version of webtrees 2.0.16 --> only "Notes" supported markdown

Merci ;-)

I think Bogie should wait with the big job.

I think the developer of webtrees are not very happy with adding new configuration options.

Last, but not least I hope that the standard behavior as per GEDCom definition (CONT = new line) will be normaly supported together with markdown - in the way it worked since ever.

Ladislav

Ladislav

webtrees 2.0.24 + ⚶ Vesta modules (from cissee.de/ )
testing webtres 2.1.5 + ⚶ Vesta modules
on PHP Version 7.4.28

Please Log in or Create an account to join the conversation.

  • Bogie
  • Bogie's Avatar
  • Offline
  • Elite Member
  • Elite Member
  • Life is good!
More
3 years 2 months ago #45 by Bogie

I think Bogie should wait with the big job.

It's just done, Ladislav, ;-) and I'm happy with the result. :-)

Bogie
webtrees 2.2.1 | PHP 8.3.12 | MariaDB 10.11.8 | Apache on Ubuntu
AutoComplete places of @tkempf, chart modules of @magicsunday, Fancy treeview of @justCarmen

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #46 by miqrogroove
Replied by miqrogroove on topic v2.0.17 - Things that no longer work after update

> Previously, a new CONT tag was translated with a <br> and an empty CONT tag with a <p>.

Previously, the CSS above was included in the core code.

This CSS should only have been included for plain-text notes - not for markdown notes.

This was a bug.

This is a uniquely hostile attitude for you. How about we make this "bug" a change to the 2.1 branch only, and let existing users of 2.0 not have all their content broken by this change?

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 2 months ago #47 by miqrogroove
Replied by miqrogroove on topic v2.0.17 - Things that no longer work after update

But, if you want "almost markdown", then a simple CSS change should give you what you want:
Code:
<style> .markdown > p { white-space: pre-wrap; } </style>

Adding this in v2.0.19 does nothing. My notes still show none of the linefeeds I entered in thousands of records. They are not specified with the markdown class in any of the page source code and I don't see how this CSS would do anything other than tweak a source citation text block.
Last edit: 3 years 2 months ago by miqrogroove.

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 2 months ago #48 by mp


Adding this in v2.0.19 does nothing. My notes still show none of the linefeeds I entered in thousands of records. They are not specified with the markdown class in any of the page source code and I don't see how this CSS would do anything other than tweak a source citation text block.

If you don't dislike addons, I can recommend the addon vesta_classic_laf for webtrees v2.0.19, so that the line breaks inserted with CONT are displayed correctly again.

If you are using the Justlight/Justblack theme, you should still use v2.0.19.0.1 of the addon for now, as there is still a small conflict in the last version.

Martin - ffp.bauschaffen.de
Last edit: 3 years 2 months ago by mp.

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 1 month ago #49 by ric2015

If you don't dislike addons, I can recommend the addon vesta_classic_laf for webtrees v2.0.19, so that the line breaks inserted with CONT are displayed correctly again.

Only as long as markdown is enabled in the tree preferences. There are two separate issues here, which are sometimes mixed up in the current discussions. A summary:

  • Markdown is disabled: Line breaks are not preserved in many cases, see this summary . This is a bug that has to be fixed in webtrees, Vesta does not address this issue.
  • Markdown is enabled: Line breaks are not preserved by design. This is a webtrees feature, which Vesta reverts. Other solutions have been suggested for this case, which unfortunately only work partially:

    • the CSS fix does not cover all cases, because markdown doesn't always appear within a 'markdown' class
    • adding two spaces before each line break doesn't work for webtrees 1.x census assistant notes


Finally, if you use the CSS fix (e.g. via the JustLight theme) and the Vesta module, you currently end up with double line breaks in some cases. I'll address this in the next Vesta release.

Richard

webtrees 2.2.0 at cissee.de/webtrees2
Vesta custom modules (Classic Look & Feel, Gov4webtrees, Shared Places, Extended Relationships) available at cissee.de
Last edit: 3 years 1 month ago by ric2015.

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 2 months ago #50 by miqrogroove
Replied by miqrogroove on topic v2.0.17 - Things that no longer work after update
Thanks for the ideas but I don't need my site to look like v1 and I have no knowledge of this GEDCOM formatting stuff or why any of this would change in an update. I just want the notes that I wrote in webtrees to not be corrupted. I'll restore 2.0.16 from backup and figure out how to turn off the update nags if nobody has a simple reversion for this.
Last edit: 3 years 2 months ago by miqrogroove.

Please Log in or Create an account to join the conversation.

  • norwegian_sardines
  • norwegian_sardines's Avatar
  • Offline
  • Platinum Member
  • Platinum Member
More
3 years 2 months ago #51 by norwegian_sardines
Replied by norwegian_sardines on topic v2.0.17 - Things that no longer work after update
miqrogroove,

Your NOTEs are not corrupted! The display is just not honoring the line break in some cases, but the NOTE:CONT cards in the GEDCOM file are not being changed!

If you stay at 2.0.19 you will only be seeing the NOTE cards/tags displayed without line breaks on the specific pages I outlined, the same NOTE cards/tags are display with line breaks on other pages!

Ken

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 2 months ago #52 by miqrogroove
Replied by miqrogroove on topic v2.0.17 - Things that no longer work after update
norwegian_sardines, I don't know what your point is. If I can't read my own notes then I'm restoring my 2.0.16 backup.
Last edit: 3 years 2 months ago by miqrogroove.

Please Log in or Create an account to join the conversation.

  • norwegian_sardines
  • norwegian_sardines's Avatar
  • Offline
  • Platinum Member
  • Platinum Member
More
3 years 2 months ago #53 by norwegian_sardines
Replied by norwegian_sardines on topic v2.0.17 - Things that no longer work after update
miqrogroove,

You used the word "corrupted", This word often can infer that the data was "damaged", the NOTEs were not damaged, just not displayed correctly. In your mind this may be splitting hairs, but to computer people a corrupted file means the file itself has been altered, in this case the file has not been altered!

You are welcome to revert back so your display is correct.

Ken

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #54 by miqrogroove
Replied by miqrogroove on topic v2.0.17 - Things that no longer work after update
Database schema hasn't changed, so I branched my v2.0.16 customizations and added /app/Services/UpgradeService.php

In fetchLatestVersion the update checking can be disabled by overwriting the function as follows.
Code:
private function fetchLatestVersion(): string { return '2.0.16|2.0.0|https://github.com/fisharebest/webtrees/releases/download/2.0.16/webtrees-2.0.16.zip'; }

Please Log in or Create an account to join the conversation.

More
3 years 1 month ago - 3 years 1 month ago #55 by markhattam
Replied by markhattam on topic v2.0.17 - Things that no longer work after update
How do I get this GEDCOM to display with line breaks ... using 2.0.19

The blank CONT lines seem to be ignored and (even worse) the following CONT is ignored too, running the next line on the same line as the previous.
Code:
2 SOUR @SR1@ 3 PAGE 1 3 DATA 4 DATE 29 MAR 1921 4 TEXT Name: Henry Thomas Hattam 5 CONT Age: 26 years 5 CONT Condition: Bachelor 5 CONT Profession: Metropolitan Police Constable 5 CONT Residence: Police Section House, Tottenham Lane, Hornsey 5 CONT Father's name: Thomas Hattam 5 CONT Father's profession: Farmer 5 CONT 5 CONT Name: Alice Maud Osborne 5 CONT Age: 28 years 5 CONT Condition: Spinster 5 CONT Profession: Elementary School Teacher 5 CONT Residence: 15 Princess Street, St Just 5 CONT Father's name: John Tippett Osborne (deceased) 5 CONT Father's profession: Farmer 5 CONT 5 CONT Married in the Wesleyan Chapel according to the Rites and Ceremonies of the Wesleyan Methodists by Certificate. 5 CONT 5 CONT Witnesses: 5 CONT Harry Hattam 5 CONT George T Barnicoat 5 CONT 5 CONT In the presence of: 5 CONT Thomas Little, Wesleyan Minister 5 CONT Joseph E Rowe, Registrar

The source code from the webpage is clearly missing the expected pair of <br /> for the blank lines.
Code:
<div><span class="label">Text</span>: <span class="value align-top"><div dir="auto"><p>Name: Henry Thomas Hattam<br /> Age: 26 years<br /> Condition: Bachelor<br /> Profession: Metropolitan Police Constable<br /> Residence: Police Section House, Tottenham Lane, Hornsey<br /> Father's name: Thomas Hattam<br /> Father's profession: FarmerName: Alice Maud Osborne<br /> Age: 28 years<br /> Condition: Spinster<br /> Profession: Elementary School Teacher<br /> Residence: 15 Princess Street, St Just<br /> Father's name: John Tippett Osborne (deceased)<br /> Father's profession: FarmerMarried in the Wesleyan Chapel according to the Rites and Ceremonies of the Wesleyan Methodists by Certificate.Witnesses:<br /> Harry Hattam<br /> George T BarnicoatIn the presence of:<br /> Thomas Little, Wesleyan Minister<br /> Joseph E Rowe, Registrar</p></div>

Last edit: 3 years 1 month ago by markhattam. Reason: Putting attachment into the message

Please Log in or Create an account to join the conversation.

More
3 years 1 month ago - 3 years 1 month ago #56 by ric2015

How do I get this GEDCOM to display with line breaks ... using 2.0.19

The blank CONT lines seem to be ignored

First, you should not have to modify your GEDCOM like this just to work around the current issues. In particular if you have markdown disabled, my suggestion is to wait for webtrees to fix the display bug. There is an open issue for this (as well as several other related issues).

Overall there are different cases and proposed solutions, see my summary here .

Richard

webtrees 2.2.0 at cissee.de/webtrees2
Vesta custom modules (Classic Look & Feel, Gov4webtrees, Shared Places, Extended Relationships) available at cissee.de
Last edit: 3 years 1 month ago by ric2015.

Please Log in or Create an account to join the conversation.

More
3 years 1 month ago #57 by markhattam
Replied by markhattam on topic v2.0.17 - Things that no longer work after update
Markdown is not enabled ... I did try it briefly once I discovered where to enable it, but it looked even worse on the displayed webpage.
I use the default webtrees theme.

Please Log in or Create an account to join the conversation.

More
3 years 1 month ago #58 by mp

Markdown is not enabled ... I did try it briefly once I discovered where to enable it, but it looked even worse on the displayed webpage.
I use the default webtrees theme.

In this case you have to wait for a bug fix and maybe downgrade again to v2.0.16.

Martin - ffp.bauschaffen.de

Please Log in or Create an account to join the conversation.

  • norwegian_sardines
  • norwegian_sardines's Avatar
  • Offline
  • Platinum Member
  • Platinum Member
More
3 years 1 month ago - 3 years 1 month ago #59 by norwegian_sardines
Replied by norwegian_sardines on topic v2.0.17 - Things that no longer work after update
X

Ken
Last edit: 3 years 1 month ago by norwegian_sardines.

Please Log in or Create an account to join the conversation.

More
3 years 1 month ago #60 by markhattam
Replied by markhattam on topic v2.0.17 - Things that no longer work after update
Downgrading to a less secure version isn't generally a good idea.

So, what I have just done is grep replace in my GEDCOM file all my
5 CONT
with
5 CONT  
(ie replacing nothing after CONT with a space and an option-space)

And re-imported the GEDCOM.

Now the data displays as it ought to, and the webpage source code shows the lines with a <space><br />
Code:
<div><span class="label">Text</span>: <span class="value align-top"><div dir="auto"><p>Name: Henry Thomas Hattam<br /> Age: 26 years<br /> Condition: Bachelor<br /> Profession: Metropolitan Police Constable<br /> Residence: Police Section House, Tottenham Lane, Hornsey<br /> Father's name: Thomas Hattam<br /> Father's profession: Farmer<br /> <br /> Name: Alice Maud Osborne<br /> Age: 28 years<br /> Condition: Spinster<br /> Profession: Elementary School Teacher<br /> Residence: 15 Princess Street, St Just<br /> Father's name: John Tippett Osborne (deceased)<br /> Father's profession: Farmer<br /> <br /> Married in the Wesleyan Chapel according to the Rites and Ceremonies of the Wesleyan Methodists by Certificate.<br /> <br /> Witnesses:<br /> Harry Hattam<br /> George T Barnicoat<br /> <br /> In the presence of:<br /> Thomas Little, Wesleyan Minister<br /> Joseph E Rowe, Registrar</p></div></span></div></div>



I need to do my
1 CONT
lines as well.

Please Log in or Create an account to join the conversation.

Powered by Kunena Forum