Solved Lists - Individuals & Families

Marky
Topic Author
Offline
Junior Member

1 week 1 day ago - 6 days 20 hours ago #1 by Marky

Lists - Individuals & Families was created by Marky

Justification of surnames seems to have changed from left to right. The table header still justifies 'Surname' on the left.

This applies to 2.1.21 & 2.2.0.

After selecting a surname the table has no horizontal borders.

Again this applies to 2.1.21 & 2.2.0.

The surnames in the family list are no longer links in 2.1.21 but appear to be working as links in 2.2.0.

webtrees v2.1.21
PHP v8.3.12

Last edit: 6 days 20 hours ago by Marky.

Please Log in or Create an account to join the conversation.

Franz Frese
Offline
Elite Member

1 week 1 day ago #2 by Franz Frese

Replied by Franz Frese on topic Lists - Individuals & Families

+1
Raise issue at github?

For to get help, tell the address of your webtrees site!
mine is: freris.de

Please Log in or Create an account to join the conversation.

kiwi
Offline
Platinum Member

1 week 1 day ago #3 by kiwi

Replied by kiwi on topic Lists - Individuals & Families

Or it might already be fixed:

github.com/fisharebest/webtrees/commit/f...bf32193c8600d2e0c78d

Nigel
www.our-families.info

Please Log in or Create an account to join the conversation.

Marky
Topic Author
Offline
Junior Member

1 week 1 day ago #4 by Marky

Replied by Marky on topic Lists - Individuals & Families

> Or it might already be fixed: github.com/.....

I think that's a separate issue.

This seems to do with tables in general.

Justification in table header fields and data fields seems inconsistant e.g. for recent changes:

webtrees v2.1.21
PHP v8.3.12

Please Log in or Create an account to join the conversation.

kiwi
Offline
Platinum Member

1 week 1 day ago - 1 week 1 day ago #5 by kiwi

Replied by kiwi on topic Lists - Individuals & Families

Marky wrote:
> Or it might already be fixed: github.com/.....

I think that's a separate issue.

This seems to do with tables in general.

Justification in table header fields and data fields seems inconsistant e.g. for recent changes:

I was only referring just to this:

The surnames in the family list are no longer links in 2.1.21 but appear to be working as links in 2.2.0.

That issue is unlikely to be anything related ti the table border issues. So if it’s not related to the link I gave (I’m not able to test it today) it will need a separate github issue.

Nigel
www.our-families.info

Last edit: 1 week 1 day ago by kiwi.

Please Log in or Create an account to join the conversation.

raaspt
Offline
New Member

1 week 1 day ago #6 by raaspt

Replied by raaspt on topic Lists - Individuals & Families

The new releases have an upgraded version of DataTables (v2), which is autodetecting the surnames as numbers, which then get aligned to the right via CSS (vendor.min.css).

If you can't wait for an official fix, a workaround is to edit line 50 of "\resources\views\lists\surnames-table.phtml" file and replace

Code:

<td data-sort="<?= $n = 1 + ($n ?? 0) ?>">

Code:

<td class="text-left" data-sort="<?= $n = 1 + ($n ?? 0) ?>">

I don't recommend changing source code on your own unless you know what you're doing, and if you do make sure you backup the original file.

Please Log in or Create an account to join the conversation.

fisharebest
Offline
Administrator

1 week 1 day ago #7 by fisharebest

Replied by fisharebest on topic Lists - Individuals & Families

I think this is a bug in version 2 of datatables.

I have created an issue with datatables:
github.com/DataTables/DataTablesSrc/issues/306

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

raaspt
Offline
New Member

1 week 1 day ago - 1 week 1 day ago #8 by raaspt

Replied by raaspt on topic Lists - Individuals & Families

Hi Greg,

Please check github.com/DataTables/DataTablesSrc/issues/303 and datatables.net/forums/discussion/78320/h...etected-columns-type .

Thanks

Last edit: 1 week 1 day ago by raaspt.

Please Log in or Create an account to join the conversation.

Franz Frese
Offline
Elite Member

1 week 1 day ago - 1 week 1 day ago #9 by Franz Frese

Replied by Franz Frese on topic Lists - Individuals & Families

the alignment right is not a problem (for me), but the missing hyperlink has to be corrected/activated (or is it already done?)!

the fix#5059 is already included in the 2.1.21 release and so does not solve the issue!

For to get help, tell the address of your webtrees site!
mine is: freris.de

Last edit: 1 week 1 day ago by Franz Frese.

Please Log in or Create an account to join the conversation.

Marky
Topic Author
Offline
Junior Member

1 week 1 day ago #10 by Marky

Replied by Marky on topic Lists - Individuals & Families

Just to clarify, it looks like there are 3 issues:

1. Data table field alignment (cosmetic)
Problem in 2.1.21, 2.2.0 & 2.2.0(beta/dev).
Caused by a new version of datatables.

2. Data table missing horizontal lines (cosmetic)
Problem in 2.1.21, 2.2.0 & 2.2.0(beta/dev).
Seen in individual and families list (details page).
Vertical lines have also changed - table boundary lines (far right & left) look OK but internal lines seem heavier.

3. Family names in surname list are no longer links (functional)
Problem in 2.1.21 & 2.2.0(beta/dev) but works in 2.2.0.

Do any of these need github'ing?

webtrees v2.1.21
PHP v8.3.12

Please Log in or Create an account to join the conversation.

fisharebest
Offline
Administrator

1 week 1 day ago #11 by fisharebest

Replied by fisharebest on topic Lists - Individuals & Families

I fixed (1) earlier today.
I am fixing (3) now.

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.

Marky
Topic Author
Offline
Junior Member

1 week 4 hours ago #12 by Marky

Replied by Marky on topic Lists - Individuals & Families

Re. issue 2 - table borders.

Adding the following CSS reverts table borders to how they looked in 2.1.20.

Code:

.table-bordered { border-collapse: collapse; }

I can see how 2 adjacent vertical borders would collapse into 1 border but I have no idea why it would make the horizontal borders (previously missing) now appear!

webtrees v2.1.21
PHP v8.3.12

Please Log in or Create an account to join the conversation.

fisharebest
Offline
Administrator

1 week 3 hours ago #13 by fisharebest

Replied by fisharebest on topic Lists - Individuals & Families

I have just submitted a fix for this.

We had logic to set the border-collapse, but a class-name had changed during the datatables upgrade so it wasn' being applied.

Greg Roach - greg@subaqua.co.uk - @fisharebest@phpc.social - fisharebest.webtrees.net

Please Log in or Create an account to join the conversation.