Question Custom module errors with webtrees 2.2.0: Call to undefined function app/make

After installing the new webtrees 2.2.0 version, several custom modules throw error messages:

1. Call to undefined function Jefferson49\Webtrees\Module\ExtendedImportExport\app()
2. Call to undefined method Fisharebest\Webtrees\Webtrees::make()

ExtendedImportExport, FancyResearchLinks, FancyTreeview, RepositoryHierarchy, webtrees-branch-statistics:

Fatal error in module: extended_import_export
Error: Call to undefined function Jefferson49\Webtrees\Module\ExtendedImportExport\app() in C:\wamp64\www\webtrees\modules_v4\extended_import_export\DownloadGedcomWithURL.php:221 Stack trace: #0 C:\wamp64\www\webtrees\modules_v4\extended_import_export\module.php(57): Jefferson49\Webtrees\Module\ExtendedImportExport\DownloadGedcomWithURL->__construct() #1 C:\wamp64\www\webtrees\app\Services\ModuleService.php(722): include('C:\\wamp64\\www\\w...') #2 C:\wamp64\www\webtrees\app\Services\ModuleService.php(702): Fisharebest\Webtrees\Services\ModuleService::load('C:\\wamp64\\www\\w...') #3 [internal function]: Fisharebest\Webtrees\Services\ModuleService::Fisharebest\Webtrees\Services\{closure}('C:\\wamp64\\www\\w...', 1)

GV Export:

Fatal error in module: GVExport
Error: Call to undefined method Fisharebest\Webtrees\Webtrees::make() in C:\wamp64\www\webtrees\modules_v4\GVExport\module.php:414 Stack trace: #0 C:\wamp64\www\webtrees\app\Services\ModuleService.php(722): include() #1 C:\wamp64\www\webtrees\app\Services\ModuleService.php(702): Fisharebest\Webtrees\Services\ModuleService::load('C:\\wamp64\\www\\w...') #2 [internal function]: Fisharebest\Webtrees\Services\ModuleService::Fisharebest\Webtrees\Services\{closure}('C:\\wamp64\\www\\w...', 2)

Does webtrees 2.2 include some changes in the custom module API, which need to be adopted? Or is it a bug? 

This is a change in the core code, and will need a small change in the module.

webtrees uses a number of libraries and conventions from the Laravel framework. One of these is that the function app() is used to access the dependency-injection container.

i.e. if you want to create an object of type Foo, you would previously have used app(Foo::class).

Firstly, this has issues with testing, and secondly it is considered bad practice to create functions in the global namespace.

So, in 2.2, the container is accessed via a "service-locator/registry" system.

In short,

app(Foo::class) becomes Registery::container()->get(Foo::class)

fisharebest wrote:

So, in 2.2, the container is accessed via a "service-locator/registry" system.

In short,

app(Foo::class) becomes Registery::container()->get(Foo::class)

Thank you Greg for the fast explanation. I agree that it is easy to change. It took only some minutes to fix it in my modules. However, it seems to work only in 2.2. To be still compatible with 2.1., it seems that the webtrees version needs to be checked.

Is this the right way to go?
 

2.2 also requires a minimum version of php (8.3).
So perhaps better to create a “2.2 compatible “ version and leave the 2.1 version alone?

kiwi wrote:

2.2 also requires a minimum version of php (8.3).
So perhaps better to create a “2.2 compatible “ version and leave the 2.1 version alone?
 

When adjusting the Vesta modules for webtrees 2.2, I didn't encounter any backwards-incompatible php issues, so apart from the issue mentioned by Jefferson49 it's not too problematic to create a custom module release that works with both 2.1.21 and 2.2 (and php 8.2 - 8.4).

I ended up putting all calls to the container (including that version check) into separate helper methods (webtrees itself had those helper methods in 2.1.x: app/Webtrees::make() and app/Webtrees::set() - it would have been very helpful for custom modules if those had been kept at least in initial 2.2 releases as deprecated methods).
 

Richard

Are you saying that Vesta Modules are compatible with WebTrees 2.2.0??

I get errors similar to attached image for all Vesta Modules and they DO NOT show up in the Control Panel >> Other or >> All Modules

 

RickM wrote:

Richard

Are you saying that Vesta Modules are compatible with WebTrees 2.2.0??

I get errors similar to attached image for all Vesta Modules


 

Yes, the latest Vesta version (released yesterday) is compatible - In general, you can always determine this by checking the Readme files on github (or see the version number). As usual, the previous Vesta releases 2.1.20.x are not compatible with a higher webtrees version (normally the modules would just be made inactive internally in such a case, but this particular change in webtrees prevents this and causes the error message).
 

Hi all, I have now published a new version of GVexport that supports webtrees 2.2.0. I would have done the update earlier but I had a bit of trouble with the update. It seems the PHP module Imagick can have issues with PHP8.3, but I managed to get webtrees 2.2.0 running by disabling it.

Because of this breaking change in webtrees, the latest version of GVExport will only support webtrees 2.2.0 and up. I have also published a release with some recent unreleased changes to be the last release for 2.1.X.  I've now published a version that should support both 2.1.X and 2.2.X

See the releases section on github to grab the latest releases.

I have the same issue with several modules.

Is this something we can fix by ourself? Where does the Code need to be changed? Only a few files or a lot?

Okay, figured it out by myself. As stated above: Edit all occurrences of
to
Watch out for trailing semicolon, in very few cases there is none (e.g. jc-fancy-treeview/FancyTreeviewModule.php line 1872.)

You also have to add  somewhere (recommended somewhere to the other in the top).

Added a pull request to JustCarmen's webtrees-fancy-research-links module at  github.com/JustCarmen/webtrees-fancy-res...links/pull/104/files

By adding a helper function to support the different handling in webtrees 2.1 and 2.2, I created new releases for the following custom modules: 

•   Extended Import/Export (Advanced GEDCOM import, export, and filter operations. Also supports remote downloads/uploads via URL requests)
•   Repository Hierarchy  (... to present the structure of a repository and its sources in a hierarchical manner; also including advanced features to improve the handling of source citations)

The following modules can be used in webtrees 2.2 without any changes:

• Change Language with URL  (... to change the webtrees language by URL requests with the language provided as an URL parameter)
• My Custom Tags  (... to provide custom tags, custom types, custom relationship descriptors, and custom roles in events)

The latest versions of the custom modules can be used in both, webtrees 2.1 and 2.2

Family Tree Home Page  has been updated.

Please post this to blog on webtrees.net

So you have to replace app(Foo::class) with Registry::container()->get(Foo::class)
Okay. but I can't find the file(s) in which app(Foo::class) would be.
Can you tell me their path? (forgive my lack of skills). Thanks in advance

Which module are you talking about?
You have to replace "Foo" with the corresponding variable.

My error message is Error: Call to undefined function MyArtJaub\Webtrees\Module\app() in /homepages/29/d169090331/htdocs/webtrees/modules_v4/myartjaub_ruraltheme/module.php:170 so I guess it's about myartjaub_ruraltheme. The problem is that in module.php I can't find any app(Foo::class)

Just search for "app(" and remember if this is 3rd-party code it might need other changes.

What is in module.php on line 170?

You can't just search for "app(Foo::class)", since the "Foo" is a Placeholder, for whatever variable is there.
So if there is e.g. you have to change it to