Bienvenue, Invité
Nom d'utilisateur : Mot de passe :
Please do NOT expect all Feature Requests to be actioned automatically. Describing your proposal here will ensure the development team are aware of it, and they will give it careful consideration.
  • Page :
  • 1

SUJET :

A bug or a feature? :-) il y a 1 mois 1 semaine #1

  • WGroleau
  • Portrait de WGroleau Auteur du sujet
  • Hors Ligne
  • Membre elite
  • Membre elite
  • Messages : 1880
In editing raw GEDCOM, sometimes I can type the tag in lower case and webtrees converts it to upper case without complaint.

But if I try to add
1 birt
2 date 16 jun 1977
with or without a trailing line break, I get
Invalid GEDCOM data passed to Fact::_construct(1 birt
2 date 16 jun 1977,X2600) …/app/Fact.php:191
#0 …/app/GedcomRecord.php(1081): Fisharebest\Webtrees\Fact->__construct()
#1 …/app/GedcomRecord.php(900): Fisharebest\Webtrees\GedcomRecord->parseFacts()
#2 …/app/Http/RequestHandlers/EditRawRecordAction.php(87): Fisharebest\Webtrees\GedcomRecord->updateRecord()
#3 …/app/Http/Middleware/RequestHandler.php(54): Fisharebest\Webtrees\Http\RequestHandlers\EditRawRecordAction->handle()
#4 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\RequestHandler->process()
#5 …/modules_v4/vesta_research_suggestions/ResearchSuggestionsModule.php(304): Middleland\Dispatcher->handle()
#6 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Cissee\Webtrees\Module\ResearchSuggestions\ResearchSuggestionsModule->process()
#7 … et cetera
So, one could argue that it's incorrect to accept lower case tags, or one could argue that rejecting them should not be done.

Personally, I find it convenient to not have to hold down the shift key. But I have enough OCD to see some value in being picky.

Perhaps Postel's advice is pertinent: "Be conservative in what you do, be liberal in what you accept from others."
--
Wes Groleau
UniGen.us/

Connexion ou Créer un compte pour participer à la conversation.

Dernière édition: par WGroleau.

A bug or a feature? :-) il y a 1 mois 1 semaine #2

  • fisharebest
  • Portrait de fisharebest
  • Hors Ligne
  • Administrateur
  • Administrateur
  • Messages : 16089
There are some who would like webtrees to "auto-magically" fix their data.

There are others who would get very angry if webtrees changed it.
Greg Roach - Cette adresse e-mail est protégée contre les robots spammeurs. Vous devez activer le JavaScript pour la visualiser. - fisharebest.webtrees.net

Connexion ou Créer un compte pour participer à la conversation.

A bug or a feature? :-) il y a 1 mois 1 semaine #3

  • WGroleau
  • Portrait de WGroleau Auteur du sujet
  • Hors Ligne
  • Membre elite
  • Membre elite
  • Messages : 1880

There are some who would like webtrees to "auto-magically" fix their data.

There are others who would get very angry if webtrees changed it.

And folks like me who are happy with some auto-changes but not others. :-)

Either way, a crash is undesirable.
--
Wes Groleau
UniGen.us/

Connexion ou Créer un compte pour participer à la conversation.

A bug or a feature? :-) il y a 1 mois 1 semaine #4

  • WGroleau
  • Portrait de WGroleau Auteur du sujet
  • Hors Ligne
  • Membre elite
  • Membre elite
  • Messages : 1880
I made some more entry errors, and the results are interesting.

If I add a 2 type married to a 1 NAME, it gets converted to 2 TYPE married

If I inadvertently add 1 type married to a name (forgetting the '2'), I get the "Invalid GEDCOM data" with stack trace

if I add 1 TYPE married to a name (forgetting the '2'), it shows on the facts page as INDI:TYPE in red

Obviously, I shouldn't be doing those things, but it would be nice to have the second one behave the same as the third.
--
Wes Groleau
UniGen.us/

Connexion ou Créer un compte pour participer à la conversation.

A bug or a feature? :-) il y a 1 mois 1 semaine #5

  • bertkoor
  • Portrait de bertkoor
  • Hors Ligne
  • Membre platinium
  • Membre platinium
  • Greetings from Utrecht, Holland
  • Messages : 2705
Manual input should not cause a stack trace.

It would be more interesting imho to see the behaviour of these cases on import.
stamboom.BertKoor.nl runs on webtrees v1.7.13

Connexion ou Créer un compte pour participer à la conversation.

A bug or a feature? :-) il y a 1 mois 1 semaine #6

This is all interesting, but given the limited time that Greg and the other developers have, I would really question if it is worth ANY time at all correcting errors that users introduce through editing raw GEDCOM records. My understanding is that this is really intended as a power-user feature, and maybe there needs to be more of a "use at your own risk" warning.

You could go down an incredible rabbit-hole of ever-increasing validation complexity that simply makes the product bloated and fragile, without adding any real value.

Personally I'd rather see time spent improving the UX and database.

Just my own thoughts

Eric

Connexion ou Créer un compte pour participer à la conversation.

A bug or a feature? :-) il y a 1 mois 1 semaine #7

  • fisharebest
  • Portrait de fisharebest
  • Hors Ligne
  • Administrateur
  • Administrateur
  • Messages : 16089
I have added some validation to the "Edit raw GEDCOM" forms.

They will now prevent you from submitting data that doesn't contain valid levels/tags
Greg Roach - Cette adresse e-mail est protégée contre les robots spammeurs. Vous devez activer le JavaScript pour la visualiser. - fisharebest.webtrees.net

Connexion ou Créer un compte pour participer à la conversation.

A bug or a feature? :-) il y a 1 semaine 5 jours #8

This is all interesting, but given the limited time that Greg and the other developers have, I would really question if it is worth ANY time at all correcting errors that users introduce through editing raw GEDCOM records. My understanding is that this is really intended as a power-user feature

Since I installed webtrees 2 I can't add notes or shared notes to research tasks when using the 'normal' webtrees edit page. Currently, the only way for me to do so is by editing raw GEDCOM records. I do this with a lot of care, but I'm not perfect, so if there is some "auto-magic" around to help me, I'm grateful for that....

Connexion ou Créer un compte pour participer à la conversation.

Avez-vous besoin d'une solution d'hébergement web pour votre site webtrees ?
Si vous préférez un hébergeur spécialisé de webtrees, la page suivante en liste quelques-uns capables de vous offrir ce type de service :
  • Page :
  • 1
Propulsé par Kunena